refact(brave-install): simplify script #980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 11:24
adamperkowski
changed the title
adamperkowski
approved these changes
Jan 10, 2025
adamperkowski
requested changes
Jan 10, 2025
There was a problem hiding this comment.
i think we should remove brave installation entirely if there's a one-line universal solution. @ChrisTitusTech ?
Linutil has options to install firefox, chromium, etc, even though they're essentially the same line regardless of distro. I think it's better to keep it around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
So the folks at Brave made an all-in-one curl script for Linux, so just using that is better than the mess we have today.
Testing
Tested and works
Checklist