Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common-service): runit support #985

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Jaredy899
Copy link

@Jaredy899 Jaredy899 commented Dec 24, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

I have updated the service script to address runit

Testing

Tested in Void Linux and Antix

Issues / other PRs related

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Jaredy899 Jaredy899 marked this pull request as ready for review December 24, 2024 12:55
@Jaredy899 Jaredy899 mentioned this pull request Dec 24, 2024
12 tasks
@adamperkowski adamperkowski changed the title Update common-service-script for runit feat(common-service): runit support Jan 2, 2025
@adamperkowski adamperkowski added the enhancement New feature or request label Jan 10, 2025
Comment on lines +54 to +58
runit)
"$ESCALATION_TOOL" mkdir -p "/run/runit/supervise.$1"
"$ESCALATION_TOOL" ln -sf "/etc/sv/$1" "/var/service/"
sleep 5
;;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    runit)
        "$ESCALATION_TOOL" ln -sf "/etc/sv/$1" "/var/service/"
        ;;

Ultimately it can work like this. The problem I'm having is when installing docker, this error "warning: docker: unable to open supervise/ok: file does not exist" and shows it failing. However when i immediately rerun the script, it shows docker is installed and when I check, it's running. Honestly I'm at the limits of how to fix this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runit)
    "$ESCALATION_TOOL" ln -sf "/etc/sv/$1" "/var/service/"
    sleep 5
    ;;

this is the only way i can get it to work without errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Scripts Failing on non Systemd Debian Distributions
3 participants