-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Void linux support #986
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks OK. i know i'm asking for much but did you test every single thing that could break (more complex scripts) on a fresh installation? not approving for now.
I double checked everything and made some minor changes to ensure everything works smoothly. Ran on fresh void-xfce on proxmox. also made a change to the common-service-script as it wasn't working right with docker. But now it does. |
runit) | ||
"$ESCALATION_TOOL" mkdir -p "/run/runit/supervise.$1" | ||
"$ESCALATION_TOOL" ln -sf "/etc/sv/$1" "/var/service/" | ||
sleep 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay. why is it sleeping here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gives it time to set up the supervision. I had it set at 2 but it was failing. Seems to work at 5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't really like this approach to be honest. is there no other way? i don't understand the logic here.
* chore: update copyright year (ChrisTitusTech#988) * refact: minor fixes (ChrisTitusTech#971) * Fix unused float handle mouse function, pub mod appstate Fix unnecessary usage of pub mod for appstate and resolve unused float handle mouse function * Resolve clippy warnings Remove explicit lifetime for floatcontent impl. Use div_ceil instead of manually calculating the rows for hints * chore(release): prepare for 25.1.10 (ChrisTitusTech#991) * Update linutil.yml (ChrisTitusTech#993) --------- Co-authored-by: Adam Perkowski <[email protected]> Co-authored-by: Jeevitha Kannan K S <[email protected]> Co-authored-by: Chris Titus <[email protected]>
Type of Change
Description
Add Void Linux support for many applications, also utilizing my previous common-service-script.
Testing
Tested in Void Linux
Issues / other PRs related
Dependent on PR #985
Checklist