Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got 500 and SSLError on some urls #13

Open
kpstsp opened this issue Sep 23, 2019 · 1 comment
Open

Got 500 and SSLError on some urls #13

kpstsp opened this issue Sep 23, 2019 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@kpstsp
Copy link
Contributor

kpstsp commented Sep 23, 2019

Describe the bug
If try to check some urls got a Internal service error (500)
Following deeper in code I found that cause in

requests.exceptions.SSLError

To Reproduce
Steps to reproduce the behavior:

  1. Paste 'https://www.old.reddit.com' to textbox

  2. Click on 'Check'

  3. If enabled Debug in run.py, can catch exception via console:
    requests.head(url, timeout=2, stream=True, allow_redirects=True)

  4. See error

File "/Users/trx/.virtualenvs/servermon/lib/python3.7/site-packages/requests/adapters.py", line 514, in send raise SSLError(e, request=request)

requests.exceptions.SSLError: HTTPSConnectionPool(host='www.old.reddit.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError("hostname 'www.old.reddit.com' doesn't match either of '*.reddit.com', 'reddit.com', '*.redditmedia.com', 'redditmedia.com', '*.redd.it', 'redd.it', 'www.redditstatic.com', 'i.reddituploads.com', '*.thumbs.redditmedia.com', 'www.redditinc.com', 'redditinc.com'")))
`

Expected behavior
Should show real status, maybe better add a warning about SSL, or ignore it

Desktop (please complete the following information):

  • OS: Mac OS X Mojave
  • Browser Firefox
  • Version 69.0

Additional context
Need wrap exception or do workaround. I'm don't sure what is better. Should programm check SSL or not?
Possible ignore it:
https://stackoverflow.com/questions/10667960/python-requests-throwing-sslerror

Example:
requests.get('https://kennethreitz.com', verify=False)

PS: I can take to work this issue after your decide what need to do with this error

@ChristianLutzCL
Copy link
Owner

The whole monitoring system is a bit of a mess right now.
Ignoring SSL would be a good solution I think because there is no much reason to do so anyway.

I assigned this Issue to you.
Thanks for your help!

@ChristianLutzCL ChristianLutzCL added the bug Something isn't working label Sep 24, 2019
@ChristianLutzCL ChristianLutzCL added the wontfix This will not be worked on label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants