Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #51

Open
thegaryking opened this issue Jul 31, 2023 · 9 comments
Open

typo #51

thegaryking opened this issue Jul 31, 2023 · 9 comments

Comments

@thegaryking
Copy link
Collaborator

a suggestion from

Byeongdon Oh [email protected]

"Ps. I might have found a typo in the MatchingFrontier Vignette (here). You may want to change "frontierEst()" to "estimateEffects()" on page 7."

@ChristopherLucas
Copy link
Owner

The documentation on that website hasn't kept up, especially since Noah took over the repo. I can't remember if we linked to that website anywhere, but I could either delete it entirely or leave a pointer to Noah's git repo?

@ngreifer
Copy link
Collaborator

ngreifer commented Aug 1, 2023

Yeah, that whole document is outdated if the user is using the version on the IQSS GitHub (v4.0.0 or greater). That version has plenty of documentation, but the only documentation that is relevant for it is on that website (so some other materials around the web will be outdated). @thegaryking, someone recently mentioned that the link to install the package on your website refers to an old version, so maybe you should update it. I have been working on the package here and there; do you think it would be okay to put it on CRAN at this point?

@thegaryking
Copy link
Collaborator Author

thegaryking commented Aug 1, 2023 via email

@ChristopherLucas
Copy link
Owner

That makes sense to me.

What if we remove the installation and documentation tabs from that website, then on the front page link to @ngreifer's git repo, which is the most up-to-date? That preserves the link (which we included in the AJPS article) but consolidates documentation so we don't have to update docs in multiple locations.

@ngreifer
Copy link
Collaborator

ngreifer commented Aug 1, 2023

Yes, I think that is a good idea (also remove the mailing list, since GitHub issues is a better place for discussion). You could also make it so that the link in the AJPS article automatically redirects to https://iqss.github.io/MatchingFrontier/ and remove that page entirely. I don't have access to that website so I can't update it.

@ChristopherLucas
Copy link
Owner

You could also make it so that the link in the AJPS article automatically redirects to https://iqss.github.io/MatchingFrontier/

Good idea. I'll do that.

@thegaryking
Copy link
Collaborator Author

thegaryking commented Aug 1, 2023 via email

@ngreifer
Copy link
Collaborator

ngreifer commented Aug 1, 2023

Okay, I updated the site to include the relevant links and instructions and removed the mailing list. Make sure everything looks okay.

https://projects.iq.harvard.edu/frontier/home

The website is loading very slowly today.

@ChristopherLucas
Copy link
Owner

Looks good to me, thanks Noah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants