Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Version Check in Installation Script (install.sh) when using 'latest' #185

Open
Ian-Rowland-i2 opened this issue Dec 7, 2023 · 0 comments
Labels
bug Something isn't working low priority Low priority

Comments

@Ian-Rowland-i2
Copy link

PR #182 (skip installation if specified version is installed) only satisfies the use case where the version number supplied is not 'latest' (i.e. the default value for 'version' when calling the install command).

If a version is not supplied (and so defaults to 'latest') then the following code will not match and an uninstall and reinstall will occur:

elif aws --version | grep "${AWS_CLI_STR_AWS_CLI_VERSION}"; then

In this case, it is necessary to identify the latest version available and then compare the result to the version installed.

N.B. For Windows, you can't assume that the latest version reported here is also the latest version available at Chocolatey.org (as there is usually a time lag for the site to be updated with the new version!)

@brivu brivu self-assigned this Dec 12, 2023
@brivu brivu removed their assignment May 30, 2024
@marboledacci marboledacci added bug Something isn't working low priority Low priority labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Low priority
Projects
None yet
Development

No branches or pull requests

3 participants