Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup not creating fully up to date credentials file #198

Open
jpeeler opened this issue May 10, 2024 · 0 comments
Open

setup not creating fully up to date credentials file #198

jpeeler opened this issue May 10, 2024 · 0 comments

Comments

@jpeeler
Copy link

jpeeler commented May 10, 2024

I'm using a local runner, so the environment is not created from scratch for every job. The problem I'm experiencing is that when short lived credentials are utilized (aws_session_token) followed by a job using normal credentials, the existing session token is not removed from the configuration file. I would think it's okay to empty the credentials file before repopulating, but maybe a safer alternative is a move operation to a backup file? Or perhaps at a minimum the orb should warn that the file has not been fully updated.

if [ -n "${AWS_CLI_STR_SESSION_TOKEN}" ]; then
aws configure set aws_session_token \
"${AWS_CLI_STR_SESSION_TOKEN}" \
--profile "$AWS_CLI_STR_PROFILE_NAME"

Sounds closely related to #139.

In the meantime, I suppose I'll ensure to remove the credentials file manually after a job is completed.

@jpeeler jpeeler changed the title credentials file not cleaned up setup not creating fully up to date credentials file May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant