Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug: Fix Circuit generation from the combinational analysis / boolean logic table. #468

Open
1 task done
Arnabdaz opened this issue Feb 10, 2025 · 14 comments · May be fixed by #497
Open
1 task done

🐞 Bug: Fix Circuit generation from the combinational analysis / boolean logic table. #468

Arnabdaz opened this issue Feb 10, 2025 · 14 comments · May be fixed by #497
Assignees
Labels
🐞 bug Something isn't working help wanted Extra attention is needed

Comments

@Arnabdaz
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues.

Describe the bug

Currently creating a circuit from the Combinational analysis / boolean logic table creates a broken circuit.

Image

Steps to Reproduce

  1. Click Tools > Combinational Analysis
  2. Enter a Boolean function (e.g. ABC)
  3. click next , it generates the boolean table
  4. Now click generate circuit

Expected Behavior

The generated circuit should not be broken, Reproduce the same steps in old simulator to generate a working circuit.

Image

Screenshots

No response

Is the faced issue/bug related to the Vue simulator?

Yes

Used Vue simulator with or without backend?

Without Backend

Is the bug present only on the dev server, the build, or both?

Both

Device Information

OS: Mac os
Browser: Chrome, firefox
Version: latest

Additional Context

No response

Are you working on this issue?

No

@Arnabdaz Arnabdaz added pending triage issue yet to be reviewed by maintainers 🐞 bug Something isn't working help wanted Extra attention is needed and removed pending triage issue yet to be reviewed by maintainers labels Feb 10, 2025
@salmoneatenbybear
Copy link

salmoneatenbybear commented Feb 10, 2025

I would like to take up this issue @Arnabdaz

@salmoneatenbybear
Copy link

Thanks

@harikrishna-au
Copy link

@Arnabdaz, is it okay if I start working on this issue as well?

@salmoneatenbybear
Copy link

@harikrishna-au

Would be happy to get help on this issue... I am trying to figure out how to fix this, if you find a solution to this and can get this fixed feel free to open a pr, no issues with me... Let's get this fixed together as quickly as possible and in the best possible way

@Arnabdaz
Copy link
Member Author

@harikrishna-au you can collaborate with @salmoneatenbybear on this issue

@harikrishna-au
Copy link

@Arnabdaz I fixed the bug but have some doubts. I’d like to ask you something about the code and verify the results. This was quite challenging since it's my first issue.

@harikrishna-au
Copy link

firstissue.mp4

@Arnabdaz please go through this

@salmoneatenbybear
Copy link

@harikrishna-au

Would love to know how u fixed this can you create a pr, I can try and review it to speed up the merge process

@harikrishna-au
Copy link

@JoshVarga @wallento @devartstar I just fixed this issue. Can I open a PR?

@ThatDeparted2061
Copy link
Member

Yeah go ahead, raise the PR

@harikrishna-au
Copy link

@ThatDeparted2061 I need help raising the pull request! It's my first issue, and I'm struggling to structure the best PR. I'm facing some challenges—could you guide me through the process?

@ThatDeparted2061
Copy link
Member

ThatDeparted2061 commented Feb 14, 2025

Message me on slack, i ll help you there

@harikrishna-au
Copy link

@Arnabdaz, I really need a bit of mentoring to close this issue. Could you take a look?

@ThatDeparted2061
Copy link
Member

What do you need help with ?

@harikrishna-au harikrishna-au linked a pull request Feb 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working help wanted Extra attention is needed
Projects
None yet
4 participants