Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Reduce usage of set timout and set interval #469

Open
Arnabdaz opened this issue Feb 10, 2025 · 10 comments · May be fixed by #470, #441, #484 or #486
Open

Chore: Reduce usage of set timout and set interval #469

Arnabdaz opened this issue Feb 10, 2025 · 10 comments · May be fixed by #470, #441, #484 or #486
Labels
good first issue Good for newcomers

Comments

@Arnabdaz
Copy link
Member

Arnabdaz commented Feb 10, 2025 •
edited
Loading

Describe the issue

In the vue js code base there are places where we used set interval or set timeout, we want to replace them with vue lifecycle hooks which would reduce the load on browsers for end users.

Expected Behavior

The usage of set timeout and set interval should be minimized in the vue files.

Is the faced issue/bug related to the Vue simulator?

Yes

Additional Context

Please make sure to test the functions you change in every possible way so that no functionalities are broken.

Are you working on this issue?

No
@Arnabdaz Arnabdaz added the good first issue Good for newcomers label Feb 10, 2025
@rxiddhi
Copy link

rxiddhi commented Feb 10, 2025

Please assign me this issue, I can work on it.

@Danish0111
Copy link

I want to work on it

@Arnabdaz
Copy link
Member Author

This issue won't be assigned to anyone its a open issue, just put the name of the file you are working on here so that others can know.

@rxiddhi
Copy link

rxiddhi commented Feb 10, 2025

I am working on the following files-
ContextMenu.vue
CombinationalAnalysis.vue
ExportProject.vue
ApplyThemes.vue

@Arnabdaz
Copy link
Member Author

Only take one file at time @rxiddhi so that others also have a chance to work as its a good first issue.

@rxiddhi
Copy link

rxiddhi commented Feb 10, 2025

sure @Arnabdaz , i will be working on CombinationalAnalysis.vue

@ThatDeparted2061
Copy link
Member

done, ApplyThemes.vue in #441

@Rustix69 Rustix69 linked a pull request Feb 10, 2025 that will close this issue
Open
@Rustix69
Copy link

Rustix69 commented Feb 10, 2025 •
edited
Loading

@Arnabdaz Done with the Properties Panel and ContextMenu

@rxiddhi
Copy link

rxiddhi commented Feb 10, 2025 •
edited
Loading

@Arnabdaz Please review my PR. Do i need to squash my commits or will they be squashed by merging? #465

@ThatDeparted2061 ThatDeparted2061 linked a pull request Feb 10, 2025 that will close this issue
Open
@Jay2006sawant
Copy link

Hello @Arnabdaz Would be working on ExportProject.vue

This was referenced Feb 14, 2025
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
6 participants
@Arnabdaz @Rustix69 @Danish0111 @ThatDeparted2061 @Jay2006sawant @rxiddhi