Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3/5 = 0.6 Add validation on room-node-installation to prevent overlapping installations. #31

Open
uliSchuster opened this issue Nov 2, 2020 · 0 comments
Labels
feature request Enhancement

Comments

@uliSchuster
Copy link
Member

uliSchuster commented Nov 2, 2020

The M:N relation between a room and the installed node has its own relation model that allows for time-sliced attribution. Because the Django ORM does not support temporal SQL extensions, there is no DB integrity check that would prevent a node being attributed to more than one room at a time. Therefore, we need to introduce a validation higher up in the stack.
This validation could happen in

  • the serialiser validation; this would be the earliest possible validation, and would need to be applied for all serialisers that alter node-to-room attributions;
  • in custom managers on the models involved. It is not quire clear to me if we would need validations on both sides of the relation (the Node and Room models), or just on the RoomNodeInstallation relationship model.
@uliSchuster uliSchuster added the feature request Enhancement label Nov 2, 2020
@jawebada jawebada changed the title Add validation on room-node-installation to prevent overlapping installations. 5 / X Add validation on room-node-installation to prevent overlapping installations. Dec 18, 2020
@uliSchuster uliSchuster changed the title 5 / X Add validation on room-node-installation to prevent overlapping installations. 3/5 = 0.6 X Add validation on room-node-installation to prevent overlapping installations. Dec 19, 2020
@uliSchuster uliSchuster changed the title 3/5 = 0.6 X Add validation on room-node-installation to prevent overlapping installations. 3/5 = 0.6 Add validation on room-node-installation to prevent overlapping installations. Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant