Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player names matching isn't case sensitive #766

Open
ActionRetro opened this issue Jul 6, 2023 · 2 comments
Open

Player names matching isn't case sensitive #766

ActionRetro opened this issue Jul 6, 2023 · 2 comments

Comments

@ActionRetro
Copy link

If I register my name as ActionRetro, and another user takes ACTIONRETRO, I can't ban ACTIONRETRO even by IP. The ban feature thinks that ActionRetro and ACTIONRETRO are the same.

image image

Additionally, it seems I cannot ban "actionr" - I get "You cannot ban yourself"

@UnknownShadow200
Copy link
Collaborator

UnknownShadow200 commented Jul 7, 2023

In truth, database name lookup when logging in should have been case insensitive from day one to avoid this sort of issue altogether, as most of the rest of MCGalaxy treats player names as case insensitive

But unfortunately, there are already existing servers out there that mistakenly have multiple entries for the same name but with differing case - and changing general name lookup to be case sensitive would cause issues for them

So I'll compromise by changing name lookup on login to be case insensitive when running on servers with name verification disabled

(but note that running a publicly accessible server with name verification disabled isn't recommended and can have other issues - see #673 for instance)

@UnknownShadow200
Copy link
Collaborator

1755ec2 (part of 1.9.4.9) should prevent being able to have multiple users with the same name but differing case, if the server is running without name verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants