Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Tooltip search not working / inconsistently #92

Open
Krutoy242 opened this issue Dec 17, 2024 · 2 comments
Open

# Tooltip search not working / inconsistently #92

Krutoy242 opened this issue Dec 17, 2024 · 2 comments

Comments

@Krutoy242
Copy link

Tooltip search (using # prefix) working inconsistently:

  1. Cant find items when prefix search just enable,
  2. After restart or toggling "Ultra Low Memory Usage Mode" it working partially - random items could be found, but other dont.

How to reproduce on E2EE modpack:

  • Tooltip search is set to require_prefix:
    image

  • Not all items that have tooltip actually considering as having tooltip:

image
image

I created new issue since my last report to this thread was not responded.

@Rongmario
Copy link
Member

I can't reproduce this when I:

  • Listened to ItemTooltipEvent and renamed select amount of items to have the tooltip line "#Tank"
  • Turned on required_prefix for tooltips
  • Searching #Tank showed up only the items with that tooltip line.
  • Searching with -##Tank Tank is the same as searching Tank (which is the same as vanilla JustEnoughItems)

@Krutoy242
Copy link
Author

Listened to ItemTooltipEvent

I dont know what is ItemTooltipEvent. I'm adding tooltips with CraftTweaker function IIngredient.addTooltip(). But this is not the only case. Sometimes, items cant be found even for modded tooltips, added with Java mod code without using CraftTweaker.

Searching with -##Tank Tank is the same as searching Tank

Maybe i don't understand how search work, but, isnt -##Tank Tank should show Items with name includes "Tank" but tooltip excludes "#Tank"?
But even if im wrong, this still not changing the issue - ##Tank search still not showing items with #Tank in their tooltips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants