Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to modify the pipeline so that we add @xml:id instead of @n #47

Open
ryderwishart opened this issue Jun 6, 2022 · 3 comments
Open
Assignees

Comments

@ryderwishart
Copy link
Contributor

No description provided.

@klosoter
Copy link
Contributor

klosoter commented Jun 7, 2022

I talked with @jonathanrobie earlier and we decided to change Node/@xml:id into Node/@n while keeping m/@xml:id because the duplicate ids create problems for some xml parsers. Does this create problems for you, @ryderwishart, at the front-end?

This has already been changed for the pull request that contains the glosses and stuff, but if we want to keep this change, we might need to change the pipeline accordingly.

@ryderwishart
Copy link
Contributor Author

I think that shouldn't create any issues. I could always adapt the lowfat accordingly if it did. Thanks for the heads up!

@jonathanrobie
Copy link
Contributor

because the duplicate ids create problems for some xml parsers

For all XML parsers that conform to the xml:id specification, to be precise, since the same xml:id occurs on both (1) the Node and (2) the <m> element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants