Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems in morpheme-mappings.xml #75

Open
themikejr opened this issue Aug 8, 2022 · 1 comment
Open

Problems in morpheme-mappings.xml #75

themikejr opened this issue Aug 8, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@themikejr
Copy link
Contributor

The dashboard team is going to be relying on the morpheme-mapping file so that ClearEngine can utilize the existing verse-based trees while the rest of the Dashboard can rely on the active work happening in the lowfat trees.

While looking at the aforementioned mapping file, I noticed the following issues:

  • The attribute that represents the current lowfat identifiers seems to be called n. Conversely, I expected to find an id or xml:id attribute which represents the lowfat trees in main.
  • The values that represent the current lowfat identifiers seem to be out of date. They do not have the leading o character and I did not see an instances where trailing hebrew consonants are included for handling the implied article.

There also may be other issues that were not obvious to me.

@themikejr themikejr added the bug Something isn't working label Aug 8, 2022
@jonathanrobie
Copy link
Contributor

Yes, I think these are both bugs. The attribute should be xml:id and it should start with n in the New Testament.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants