Skip to content

Commit 16f2ed6

Browse files
authoredSep 26, 2023
Resolve android-build tools path (aws#2685)
Fixes aws#2452 In a previous [commit](aws@de98602) a bunch of directories were moved under /tools, including android-build. At this time, scripts and CMake configurations were not updated, which has caused build failures.
1 parent 1d42774 commit 16f2ed6

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed
 

‎cmake/build_external.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ if(BUILD_CURL OR BUILD_OPENSSL OR BUILD_ZLIB)
131131
-DEXTERNAL_CXX_FLAGS=${EXTERNAL_CXX_FLAGS}
132132
-DEXTERNAL_C_FLAGS=${EXTERNAL_C_FLAGS}
133133
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
134-
${CMAKE_CURRENT_SOURCE_DIR}/android-build
134+
${CMAKE_CURRENT_SOURCE_DIR}/tools/android-build
135135
WORKING_DIRECTORY ${EXTERNAL_BUILD_DIR}
136136
RESULT_VARIABLE CONFIGURE_DEPS_EXIT_CODE)
137137

‎tools/android-build/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ if(BUILD_OPENSSL)
3939
GIT_REPOSITORY https://github.com/openssl/openssl.git
4040
GIT_TAG e2e09d9fba1187f8d6aafaa34d4172f56f1ffb72 # 1.1.1g
4141
UPDATE_COMMAND ""
42-
PATCH_COMMAND cd ${CMAKE_BINARY_DIR} && python ${AWS_NATIVE_SDK_ROOT}/android-build/configure_openssl_cmake.py --source ${AWS_NATIVE_SDK_ROOT} --dest ${OPENSSL_SOURCE_DIR}
42+
PATCH_COMMAND cd ${CMAKE_BINARY_DIR} && python ${AWS_NATIVE_SDK_ROOT}/tools/android-build/configure_openssl_cmake.py --source ${AWS_NATIVE_SDK_ROOT} --dest ${OPENSSL_SOURCE_DIR}
4343
CMAKE_ARGS
4444
-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
4545
-DCMAKE_ANDROID_NDK_TOOLCHAIN_VERSION=${CMAKE_ANDROID_NDK_TOOLCHAIN_VERSION}
@@ -66,7 +66,7 @@ if(BUILD_CURL)
6666
UPDATE_COMMAND ""
6767
PATCH_COMMAND ""
6868
CMAKE_ARGS
69-
-C ${AWS_NATIVE_SDK_ROOT}/android-build/CurlAndroidCrossCompile.cmake
69+
-C ${AWS_NATIVE_SDK_ROOT}/tools/android-build/CurlAndroidCrossCompile.cmake
7070
-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
7171
-DCMAKE_ANDROID_NDK_TOOLCHAIN_VERSION=${CMAKE_ANDROID_NDK_TOOLCHAIN_VERSION}
7272
-DANDROID_NATIVE_API_LEVEL=${ANDROID_NATIVE_API_LEVEL}

‎tools/android-build/build_and_test_android.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ def Main():
420420
InstallTests(credentialsFile)
421421

422422
print("Installing certs...")
423-
BuildAndInstallCertSet("android-build", buildDir)
423+
BuildAndInstallCertSet("tools/android-build", buildDir)
424424

425425
print("Uploading test resources")
426426
UploadTestResources("aws-cpp-sdk-lambda-integration-tests/resources")

‎tools/android-build/configure_openssl_cmake.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# openssl doesn't have any cmake files; this script copies in cmake files to appropriate directories
1111
# The CMakeFiles.txt and *.cmake files are variants of what can be found at https://github.com/janbar/openssl-cmake
1212
def CopyCMakeFiles(baseDir, destDir):
13-
sourceDir = os.path.join(baseDir, "android-build", "cmakefiles", "openssl-cmake")
13+
sourceDir = os.path.join(baseDir, "tools", "android-build", "cmakefiles", "openssl-cmake")
1414
dirLength = len(sourceDir)
1515

1616
for rootDir, dirNames, fileNames in os.walk(sourceDir):

0 commit comments

Comments
 (0)
Please sign in to comment.