-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Advanced Tutorial doc #3266
base: main
Are you sure you want to change the base?
Conversation
WIP to test formatting
fix collapsing blocks
…ckhouse-docs into tutorial-updates
Fix grammar, formatting, and cut marketing content.
Fix city name inconsistency
@@ -486,14 +501,17 @@ Let's write some queries that join the `taxi_zone_dictionary` with your `trips` | |||
ORDER BY tip_amount DESC | |||
LIMIT 1000 | |||
``` | |||
:::note | |||
Generally, we avoid using `SELECT *` often in ClickHouse. You should only retrieve the columns you actually need. However, in this example, we wanted it to be slow because why? | |||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me why you'd want this query to be slow.
|
||
<SQLConsoleDetail /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two giant screenshots seem extremely unnecessary and disruptive to the reader's experience.
@noramullen1 This is our 13th most viewed page, so thank you for the very valuable contribution! :) Spell check is failing on these words:
As they're part of a query response we just need to add them as exceptions here: https://github.com/ClickHouse/clickhouse-docs/blob/main/scripts/aspell-dict-file.txt |
Fixes #3268
Summary
Various style and grammar updates, including the following:
Remove "marketing lingo"
Organization and user experience
Example says "right join" but code shows inner join