From d3b5eff4dd22eee42b9b57906f9ea5f9f9337116 Mon Sep 17 00:00:00 2001 From: Anorak Tha Great Date: Tue, 29 Oct 2019 00:07:40 -0600 Subject: [PATCH 1/2] check prefixes & add comments --- src/chainparams.cpp | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/chainparams.cpp b/src/chainparams.cpp index 2569c1e7e1..fcf375fc0e 100644 --- a/src/chainparams.cpp +++ b/src/chainparams.cpp @@ -162,20 +162,18 @@ class CMainParams : public CChainParams { vSeeds.emplace_back("173.212.243.180"); vSeeds.emplace_back("213.136.75.147"); - /* - PUBKEY_ADDRESS = 27, // CloakCoin: address begin with 'C' - SCRIPT_ADDRESS = 85, - PUBKEY_ADDRESS_TEST = 111, - SCRIPT_ADDRESS_TEST = 196, - */ - - base58Prefixes[PUBKEY_ADDRESS] = std::vector(1,27); + // 0x1B... encodes as 'B' or 'C' Cloak public address start + base58Prefixes[PUBKEY_ADDRESS] = std::vector(1,27); + // 0x55.. base58Prefixes[SCRIPT_ADDRESS] = std::vector(1,85); - base58Prefixes[SECRET_KEY] = std::vector(1, 176); // TODO: check if value should be changed - base58Prefixes[EXT_PUBLIC_KEY] = {0x04, 0x88, 0xB2, 0x1E}; // TODO: check if value should be changed - base58Prefixes[EXT_SECRET_KEY] = {0x04, 0x88, 0xAD, 0xE4}; // TODO: check if value should be changed - - bech32_hrp = "cc"; + // 128 + PUBKEY_ADDRESS (0x9B... encodes as '6' Cloak private key start) + base58Prefixes[SECRET_KEY] = std::vector(1, 155); + // BIP-32 pubkeys start with 'xpub' (Bitcoin defaults); HD extended public key + base58Prefixes[EXT_PUBLIC_KEY] = {0x04, 0x88, 0xB2, 0x1E}; + // BIP-32 prvkeys start with 'xprv' (Bitcoin defaults); HD extended private key + base58Prefixes[EXT_SECRET_KEY] = {0x04, 0x88, 0xAD, 0xE4}; + + bech32_hrp = "cc"; // human readable part; placeholder; not using SegWit so not really important vFixedSeeds = std::vector(pnSeed6_main, pnSeed6_main + ARRAYLEN(pnSeed6_main)); From 6f3b7b669ac32cc79c67a4327598b0c8c6463990 Mon Sep 17 00:00:00 2001 From: Anorak Tha Great Date: Tue, 29 Oct 2019 00:28:17 -0600 Subject: [PATCH 2/2] add more comments --- src/chainparams.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/chainparams.cpp b/src/chainparams.cpp index fcf375fc0e..a1723e0218 100644 --- a/src/chainparams.cpp +++ b/src/chainparams.cpp @@ -222,7 +222,9 @@ class CMainParams : public CChainParams { } }; - // todo: check and set correctly! + // TODO: check and set correctly! Only relevant to estimate verification progress... + /** Guess verification progress (as a fraction between 0.0=genesis and 1.0=current tip). + // double GuessVerificationProgress(const ChainTxData& data, const CBlockIndex* pindex) */ chainTxData = ChainTxData{ // Data from rpc: getchaintxstats 4096 0000000000000000002e63058c023a9a1de233554f28c7b21380b6c9003f36a8 /* nTime */ 1532884444,