Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure block and transaction size and weight values match old codebase #33

Open
r3rcloak opened this issue Mar 20, 2019 · 1 comment
Open
Labels
question Further information is requested Sync/Consensus Issues related to block syncing / network consensus rules Task A development task

Comments

@r3rcloak
Copy link
Collaborator

r3rcloak commented Mar 20, 2019

Cloak and BTC have different consensus values blocks and transactions. Cloak also have a specific MAX_BLOCK_SIZE_GEN value for PoS generated blocks. This should be followed and updated in the new codebase.

MAX_BLOCK_SIZE and MAX_BLOCK_SIZE_GEN [PoS blocks] (in old codebase)
MAX_BLOCK_SERIALIZED_SIZE and MAX_BLOCK_WEIGHT (in new codebase).

It is also critical to ensure consensus rules match when validating transactions and blocks (see CheckTransaction in tx_verify.cpp and CheckBlock in validation.cpp). Any failure here could result in a fork due to transactions or blocks being accepted by a subset of nodes due to differing block/tx consensus rules.

@r3rcloak r3rcloak added the Task A development task label Mar 20, 2019
@r3rcloak
Copy link
Collaborator Author

This isn't critical yet but must be addressed prior to any public 'livenet' release of the new codebase.

@r3rcloak r3rcloak added question Further information is requested Sync/Consensus Issues related to block syncing / network consensus rules labels May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Sync/Consensus Issues related to block syncing / network consensus rules Task A development task
Projects
None yet
Development

No branches or pull requests

1 participant