Replace WebClient and WebRequest to HttpClient

[frg2089]

The following APIs are marked as obsolete, starting in .NET 6. Using them in code generates warning SYSLIB0014 at compile time.

SYSLIB0014 - Microsoft Learn

Add System.Net.Http.Json package to polyfill GetFromJsonAsync methods.

like this:

xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/CnCNetPlayerCountTask.cs

Lines 53 to 80 in f89c8fc

	WebClient client = new WebClient();
	Stream data = client.OpenRead("http://api.cncnet.org/status");
	string info = string.Empty;
	using (StreamReader reader = new StreamReader(data))
	{
	info = reader.ReadToEnd();
	}
	info = info.Replace("{", String.Empty);
	info = info.Replace("}", String.Empty);
	info = info.Replace("\"", String.Empty);
	string[] values = info.Split(new char[] { ',' });
	int numGames = -1;
	foreach (string value in values)
	{
	if (value.Contains(cncnetLiveStatusIdentifier))
	{
	numGames = Convert.ToInt32(value.Substring(cncnetLiveStatusIdentifier.Length + 1));
	return numGames;
	}
	}
	return numGames;

// TODO: Cached it!
// See https://learn.microsoft.com/dotnet/api/system.net.http.httpclient.-ctor?view=net-8.0#remarks
HttpClient client = new();
// TODO: make it async.
var infos = client.GetFromJsonAsync<Dictionary<string, int>>("http://api.cncnet.org/status").Result;
if (!infos.TryGetValue(cncnetLiveStatusIdentifier, out int numGames))
    numGames = -1;

return numGames;

TODO

• CnCNetPlayerCountTask

  xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/CnCNetPlayerCountTask.cs

  Line 53 in f89c8fc

  WebClient client = new WebClient();

• ExtendedWebClient

  xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/CnCNetTunnel.cs

  Line 101 in 3a2dac0

  using (var client = new ExtendedWebClient(REQUEST_TIMEOUT))

  xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/ExtendedWebClient.cs

  Line 9 in d7e370a

  class ExtendedWebClient : WebClient

• TWebClient

  xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/MapSharer.cs

  Line 381 in 6ff904f

  using (TWebClient webClient = new TWebClient())

  xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/MapSharer.cs

  Line 209 in 6ff904f

  WebRequest request = WebRequest.Create(address);

  xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/MapSharer.cs

  Line 446 in 6ff904f

  class TWebClient : WebClient

• TunnelHandler

  xna-cncnet-client/DXMainClient/Domain/Multiplayer/CnCNet/TunnelHandler.cs

  Line 156 in f89c8fc

  WebClient client = new WebClient();