Skip to content

Commit bdf21ac

Browse files
authored
fix(quickopen): prevent crash by providing UndoManagerRegistration (#2124)
Fix crash in Open Quickly preview caused by missing UndoManagerRegistration. Root cause: OpenQuicklyPreviewView renders CodeFileView in a separate view hierarchy without the environment object. Fix: Provide UndoManagerRegistration for the preview (non-editable) path so CodeFileView resolves it. Reproduce: Open Quickly (CMD+SHIFT+O) -> select a text file -> previously crashed. Validation: No crash; normal editing unaffected.
1 parent 05704cb commit bdf21ac

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

CodeEdit/Features/OpenQuickly/Views/OpenQuicklyPreviewView.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ struct OpenQuicklyPreviewView: View {
1515
@StateObject var editorInstance: EditorInstance
1616
@StateObject var document: CodeFileDocument
1717

18+
@StateObject var undoRegistration: UndoManagerRegistration = UndoManagerRegistration()
19+
1820
init(item: CEWorkspaceFile) {
1921
self.item = item
2022
let doc = try? CodeFileDocument(
@@ -29,6 +31,7 @@ struct OpenQuicklyPreviewView: View {
2931
var body: some View {
3032
if let utType = document.utType, utType.conforms(to: .text) {
3133
CodeFileView(editorInstance: editorInstance, codeFile: document, isEditable: false)
34+
.environmentObject(undoRegistration)
3235
} else {
3336
NonTextFileView(fileDocument: document)
3437
}

0 commit comments

Comments
 (0)