Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Close tab works when the 'Open Quickly' or 'Quick Actions' modal is open #1796

Closed
plbstl opened this issue Jul 5, 2024 · 0 comments · Fixed by #1868
Closed

🐞 Close tab works when the 'Open Quickly' or 'Quick Actions' modal is open #1796

plbstl opened this issue Jul 5, 2024 · 0 comments · Fixed by #1868
Labels
bug Something isn't working triage needed

Comments

@plbstl
Copy link
Contributor

plbstl commented Jul 5, 2024

Description

When the 'Open Quickly' or 'Quick Actions' modal is open, cmd+w still works and the TabBar's selected tab background does not dim.

cmd+w also closes the 'Open Quickly' and 'Quick Actions' modals.

To Reproduce

  1. Open a folder containing multiple files in CodeEdit.
  2. Double click on a few files to open them in the editor view.
  3. Use cmd shift o to show the 'Open Quickly' modal.
    • Or cmd shift p to show the 'Quick Actions' modal.
  4. Notice that the TabBar's selected tab is not dimmed.
  5. Use cmd w to close the selected tab.

Expected Behavior

When the 'Open Quickly' or 'Quick Actions' modal is open, close tab shortcut should not work.

cmd+w should not close the 'Open Quickly' or 'Quick Actions' modal

Version Information

CodeEdit: 0.1.0-dev (38)
macOS: 14.5
Xcode: 15.4

Additional Context

No response

Screenshots

CodeEdit:

codeedit.modal.close.tab.mov

Xcode:

xcode.modal.close.tab.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage needed
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

1 participant