Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool.release defined but not implemented #168

Open
larserik opened this issue Dec 26, 2022 · 1 comment
Open

Pool.release defined but not implemented #168

larserik opened this issue Dec 26, 2022 · 1 comment

Comments

@larserik
Copy link

The function release() is defined in the Pool class

release(options?: mysql.QueryOptions): Bluebird<void>;

But there is no release function in the implementation pool.js
https://github.com/CodeFoodPixels/node-promise-mysql/blob/7c075145cc981ae945ee612181e28b2c74f3e843/lib/pool.js

Is it a mistake to have it in the definition? Or is it missed to be implemented?

For example Visual Studio Code will give the release function as an autocomplete suggestion. But if you use it you will get the error TypeError: _a.release is not a function

@emilh91
Copy link

emilh91 commented Dec 23, 2024

Hi @larserik - the readme states the following; not sure if this is relevant to your issue:

Upgrading from v4 to v5
The pool.releaseConnection has been removed, please use poolConnection.release instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants