Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDEA] Modify existing models to account for patches previously made during migration #39

Open
shi-jie-samuel-tan opened this issue Aug 12, 2021 · 0 comments
Open

[IDEA] Modify existing models to account for patches previously made during migration #39

shi-jie-samuel-tan opened this issue Aug 12, 2021 · 0 comments
Assignees
@shi-jie-samuel-tan @jkdru
Labels
enhancement New feature or request

Comments

@shi-jie-samuel-tan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
A lot of database default values were manually given during the Django makemigrations process previously. This could lead to unexpected model behavior.

Describe the solution you'd like
Take note of migration ambiguity errors in the next model update and make sure all the patch work are now explicitly described in the models.py
@shi-jie-samuel-tan shi-jie-samuel-tan added the enhancement New feature or request label Aug 12, 2021
@shi-jie-samuel-tan shi-jie-samuel-tan self-assigned this Aug 12, 2021
jkdru added a commit that referenced this issue Aug 20, 2021
@jkdru
Revised models.py for prototype
571880c 
Per [issue #39](#39)
- Created actual data-source filter fields (Boolean): src_ x 6 in sites_all, so ba ref fields (hh, hwm, rhl, etc.) can be repointed to their original reference
- Added 10 other fields in sites_all and _other_srcs for potential data expansion (3 from recent stakeholder conversations + 7 placeholders)
- Converted all Enum3 to Boolean data type for consistency
Per [issue #38](#38)
- Should the 6 id_ fields in sites_all be commented out altogether, or are we just leaving their data blank in next reload?
- And/Or does this affect site_id fields in the other tables?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shi-jie-samuel-tan shi-jie-samuel-tan

@jkdru jkdru

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shi-jie-samuel-tan @jkdru