Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Map shows too many records #41

Open
jkdru opened this issue Sep 3, 2021 · 1 comment
Open

[BUG] Map shows too many records #41

jkdru opened this issue Sep 3, 2021 · 1 comment
Assignees
@isaacwasserman @donguyentung2001
Labels
bug Something isn't working

Comments

@jkdru
Copy link
Collaborator

jkdru commented Sep 3, 2021 •
edited
Loading

A clear and concise description of what the bug is.

Map shows records that are correctly hidden in tables.
Can we program map views to consistently apply the same master rule that filters records in tables? Show only if archival_only = False (Every mappable table/class has this field.)

Steps to reproduce the behavior:

  1. Go to https://matchmapper-philly.herokuapp.com/map/sites_all/
  2. Notice count at lower right: "362 of 232 records..." (first number should not be bigger)

(Screenshots and environment unnecessary)
@jkdru jkdru added the bug Something isn't working label Sep 3, 2021
@isaacwasserman
Copy link
Collaborator

ef81840 should fix this. @jkdru would you mind testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaacwasserman isaacwasserman

@donguyentung2001 donguyentung2001

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isaacwasserman @jkdru @donguyentung2001