Remove jQuery dependency

[HamedFathi]

Is it possible for you to release a version without jquery as a dependency?

Nowadays developers use Aurelia, Vue, Angular for their projects and don't need jquery.

[NullVoxPopuli]

I would like this as well (in an ember app)

[adonespitogo]

👍
I use Svelte and need a very lighweight web app. Animations can be achieved using css3

[AStoker]

Anybody attempt forking this and removing jquery?

[crazyredd]

It does not make sense for the author to remove the jQuery dependency - it is a lot of work and the JavaScript file will end up being much larger as a result. Also a lot of devs use this in tandem with jQuery for older projects that we cannot afford to upgrade to React/Angular setups.
I would suggest you either find another toast/notification library or fork this and modify it for your framework of choice.

[AStoker]

If you're using it in tandem, makes sense. If not, your overall javascript file would decrease a good proportion as you're cutting out an entire library. Yes, jQuery is used frequently, but it would be incorrect to say that most sites in the wild use jQuery. My particular case is a small web app who's overall size is smaller than the jQuery library, and all I need is a simple notification library.
YouMightNotNeedJQuery is a great site for looking at how to do things natively in Javascript instead of using jQuery.
And in other news, Github removes jQuery from its website

[crazyredd]

@AStoker You seem to have missed my point. Of course, it is entirely possible to cut out the jQuery dependency. But why should the author do so? Leaving it like that allows it to easily hook into existing projects. It makes sense to me to leave this repo as is. It is already well established as a jQuery plugin.
I am certainly not against someone forking it and removing the dependency, but I am sure there are other notification libraries out there that do exactly what you want - not every library has to work to your standards.

You may find that someone has done it already...
https://github.com/CodeSeven/toastr/network/members

[ghost]

yep - keep jquery - Nothing wrong with it as it is.

[crazyredd]

Just been looking through the source. For whatever reason it supports NodeJS.
The NodeJS runtime never supplies the window or document object, so in removing jQuery, you'd also be removing NodeJS support.

[AStoker]

I appreciate the dialog @crazyredd. Thanks for pointing out the potential window issue. I think I'll end up forking and trying to remove the dependency myself and play around with the outcome. Result should still work seamlessly with jQuery like it did before. We'll see what comes out of it 😛

[adonespitogo]

@AStoker can you provide a link to your fork - I'd like to watch and help with it

[AStoker]

@adonespitogo, once I start taking a crack at it, I'll post it here. Would be great if I identify all the places that need to be adjusted and make a checklist so others can help out.

[AStoker]

@adonespitogo, I just created a checklist document in a fork (a branch of a fork). Just threw it together real quick, it's more of a placeholder than anything else 😜 But it'll give you something to watch or contribute to.

[adonespitogo]

@AStoker nice list you put together. Although I'd prefer if we drop jquery dependency completely and rename it like toastr-lite(or something) since we don't use jquery. For people who use jquery, they can use the original toastr library.

Another idea is to create a subset of jquery functions that we can import as jquery poly-fill for projects that don't use jquery.

[AStoker]

@adonespitogo, my goal would be to limit fragmentation. Maintaining toastr-lite and toastr would prove difficult. The end result should be no noticeable difference between pre-jquery dependency and post-jquery dependency. So if somebody was already using jQuery, fine, toastr still works exactly the same. And if somebody wasn't using jQuery, same goes, toastr would work just fine. Make sense?

[JPeer264]

As my PR (#603) is still open, I did some homework. I removed jQuery and added Typescript to toastr in my repo. I will do some unit tests as soon as I have time. But it works for me at the moment.

NPM: https://www.npmjs.com/package/toastr2
GH: https://github.com/JPeer264/toastr2

EDIT:
I still do not handle any transitions yet (had no time yet to add CSS animations)

[HamedFathi]

@JPeer264

Great, Please keep up the good work.