Modified the function isProperFraction() for beter and more accurate results

Author: M-Abdoon

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -9,9 +9,14 @@
 
 function isProperFraction(numerator, denominator) {
   if(typeof(numerator) != "number" || typeof(denominator) != "number") {
-    return "[ wrong input ]";
+    throw new Error("[ wrong input ]");
   }
-  if (numerator < denominator ) {
+  
+  if ( denominator === 0) {
+    return false;
+  }
+
+  if (Math.abs(numerator) < Math.abs(denominator) ) {
     return true;
   }
   return false;
@@ -46,7 +51,7 @@ const improperFraction = isProperFraction(5, 2);
 assertEquals(improperFraction, false);
 
 // Negative Fraction check:
-// Input: numerator = -4, denominator = 7
+// Input: numerator = -4, denominator = 7 098*&7&&*
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
@@ -66,12 +71,14 @@ assertEquals(equalFraction, false);
 
 // Try 0 and a negative number check:
 // Input: numerator = -10, denominator = 0
-// target output: true
+// target output: false
 const tryZero = isProperFraction(-10, 0);
-assertEquals(tryZero, true);
+assertEquals(tryZero, false);
 
 // check if inputs are proper numbers
 // Input: numerator = "hello", denominator = 4 (any number)
 //target output: string "[ wrong input ]"
-const tryString = isProperFraction("hello", 4);
-assertEquals(tryString, "[ wrong input ]");
+
+// Uncomment to test error handling to see the assertion fail 
+// const tryString = isProperFraction("hello", 4);
+// assertEquals(tryString, "[ wrong input ]");