writing conditions and tests for password validation

Author: TzeMingHo

Sprint-3/3-stretch/password-validator.js

@@ -1,6 +1,41 @@
 function passwordValidator(password) {
-    return password.length < 5 ? false : true
-}
+  const lengthCondition = password.length >= 5;
+  console.log(`length condition: ${lengthCondition}`);
+
+  const uppercaseCondition = /[A-Z]/.test(password);
+  console.log(`upper case condition: ${uppercaseCondition}`);
+
+  const lowercaseCondition = /[a-z]/.test(password);
+  console.log(`lower case condition: ${lowercaseCondition}`);
+
+  const numberCondition = /[0-9]/.test(password);
+  console.log(`number condition: ${numberCondition}`);
 
+  const symbolCondition = /[!#$%.*&]/.test(password);
+  console.log(`symbol condition: ${symbolCondition}`);
+
+  const previousPasswords = [
+    "123Ab!",
+    "abcD1#",
+    "Password1!",
+    "Qwerty1*",
+    "Zxcvbnm2$",
+  ];
+  const notInPreviousPasswords = !previousPasswords.includes(password);
+  console.log(`previous password condition: ${notInPreviousPasswords}`);
+
+  if (
+    lengthCondition &&
+    uppercaseCondition &&
+    lowercaseCondition &&
+    numberCondition &&
+    symbolCondition &&
+    notInPreviousPasswords
+  ) {
+    return true;
+  } else {
+    return false;
+  }
+}
 
-module.exports = passwordValidator;
+module.exports = passwordValidator;

Sprint-3/3-stretch/password-validator.test.js

@@ -15,12 +15,30 @@ To be valid, a password must:
 You must breakdown this problem in order to solve it. Find one test case first and get that working
 */
 const isValidPassword = require("./password-validator");
-test("password has at least 5 characters", () => {
-    // Arrange
-    const password = "12345";
-    // Act
-    const result = isValidPassword(password);
-    // Assert
-    expect(result).toEqual(true);
-}
-);
+describe("passwordValidator", () => {
+  const password = "123Ab*";
+
+  test("returns true for passwords with at least 5 characters", () => {
+    expect(isValidPassword(password)).toBe(true);
+  });
+
+  test("return true for passwords with at least one uppercase letter", () => {
+    expect(isValidPassword(password)).toBe(true);
+  });
+
+  test("return true for passwords with at least one lowercase letter", () => {
+    expect(isValidPassword(password)).toBe(true);
+  });
+
+  test("return true for passwords with at least one number", () => {
+    expect(isValidPassword(password)).toBe(true);
+  });
+
+  test("return true for passwords with at least one non-alphanumeric symbol", () => {
+    expect(isValidPassword(password)).toBe(true);
+  });
+
+  test("return true for passwords that are not in the previous passwords array", () => {
+    expect(isValidPassword(password)).toBe(true);
+  });
+});