applied changes to ordinal and repeat functions and tests

Author: i786m

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -2,10 +2,10 @@ function getOrdinalNumber(num) {
   if (arguments.length !== 1) {
     throw new Error("Function requires exactly one argument");
   }
-  if (typeof num !== "number" || isNaN(num)) {
+  if (typeof num !== "number") {
     throw new Error("Input must be a number");
   }
-  if (!Number.isFinite(num)){
+  if (!isFinite(num)) {
     throw new Error("Input must be a finite number");
   }
   if (!Number.isInteger(num) || num < 0) {

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -83,7 +83,7 @@ test("should throw an error if the argument is a decimal", () => {
 });
 
 test("should throw an error if the argument is NaN", () => {
-  expect(() => getOrdinalNumber(NaN)).toThrow("Input must be a number");
+  expect(() => getOrdinalNumber(NaN)).toThrow("Input must be a finite number");
 });
 
 test("should throw an error if the argument is Infinity", () => {

Sprint-3/2-practice-tdd/repeat.js

@@ -1,12 +1,13 @@
 function repeat(str, count) {
   if ( arguments.length !== 2) {
-    return "Function requires exactly 2 arguments";
+    throw new Error(`Function requires exactly two arguments: a string and a count. Received ${arguments.length} arguments`);
+    
   }
   if (typeof str !== "string") {
-    return "First argument must be a string";
+    throw new Error("First argument must be a string. Received type " + typeof str);
   }
   if (!Number.isInteger(count) || count < 0) {
-    return "Second argument must be a non-negative integer";
+    throw new Error("Second argument must be a non-negative integer. Received " + count  );
   }
   return str.repeat(count);
 }

Sprint-3/2-practice-tdd/repeat.test.js

@@ -46,56 +46,56 @@ test("should return empty string if count is 0", () => {
 test("should return error message for negative count", () => {
   const str = "hello";
   const count = -2;
-  expect(repeat(str, count)).toEqual("Second argument must be a non-negative integer");
+  expect(() => repeat(str, count)).toThrow("Second argument must be a non-negative integer");
 });
 
 // invalid input tests
 test("should return error message for non-integer count", () => {
   const str = "hello";
   const count = 2.5;
-  expect(repeat(str, count)).toEqual("Second argument must be a non-negative integer");
+  expect(() => repeat(str, count)).toThrow("Second argument must be a non-negative integer");
 });
 
 test("should return error message for non-string input", () => {
   const str = 123;
   const count = 3;
-  expect(repeat(str, count)).toEqual("First argument must be a string");
+  expect(() => repeat(str, count)).toThrow("First argument must be a string");
 });
 
 test("should return error message for non-string input with invalid count", () => {
   const str = { text: "hello" };
   const count = -2;
-  expect(repeat(str, count)).toEqual("First argument must be a string");
+  expect(() => repeat(str, count)).toThrow("First argument must be a string");
 });
 
 test("should return error message for string input with non number count", () => {
   const str = "hello";
   const count = "3";
   const count2 = [];
-  expect(repeat(str, count)).toEqual("Second argument must be a non-negative integer");
-  expect(repeat(str, count2)).toEqual("Second argument must be a non-negative integer");
+  expect(() => repeat(str, count)).toThrow("Second argument must be a non-negative integer");
+  expect(() => repeat(str, count2)).toThrow("Second argument must be a non-negative integer");
 });
 
 test("should return error message for string input with NaN count", () => {
   const str = "hello";
   const count = NaN;
-  expect(repeat(str, count)).toEqual("Second argument must be a non-negative integer");
+  expect(() => repeat(str, count)).toThrow("Second argument must be a non-negative integer");
 });
 
 test("should return error message for string input with null count", () => {
   const str = "hello";
   const count = null;
-  expect(repeat(str, count)).toEqual("Second argument must be a non-negative integer");
+  expect(() => repeat(str, count)).toThrow("Second argument must be a non-negative integer");
 });
 
 test("should return error message for string input with undefined count", () => {
   const str = "hello";
   const count = undefined;
-  expect(repeat(str, count)).toEqual("Second argument must be a non-negative integer");
+  expect(() => repeat(str, count)).toThrow("Second argument must be a non-negative integer. Received undefined");
 });
 
 test('should have the correct amount of arguments', () => { 
-  expect(repeat('hello')).toEqual("Function requires exactly 2 arguments");
-  expect(repeat("hello", 3, 3)).toEqual("Function requires exactly 2 arguments"); 
+  expect(() => repeat('hello')).toThrow(new Error("Function requires exactly two arguments: a string and a count. Received 1 arguments"));
+  expect(() => repeat("hello", 3, 3)).toThrow(new Error("Function requires exactly two arguments: a string and a count. Received 3 arguments"));
  })