Correct 12-hour clock formatting and add comprehensive tests

Author: HoussamLh

Sprint-2/5-stretch-extend/format-time.js

@@ -1,25 +1,36 @@
-// This is the latest solution to the problem from the prep.
-// Make sure to do the prep before you do the coursework
-// Your task is to write tests for as many different groups of input data or edge cases as you can, and fix any bugs you find.
-
 function formatAs12HourClock(time) {
   const hours = Number(time.slice(0, 2));
-  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+  const minutes = time.slice(3, 5);
+
+  if (hours === 0) {
+    // midnight
+    return `12:${minutes} am`;
+  } else if (hours === 12) {
+    // noon
+    return `12:${minutes} pm`;
+  } else if (hours > 12) {
+    return `${hours - 12}:${minutes} pm`;
+  } else {
+    // 1am to 11am
+    return `${time} am`;
   }
-  return `${time} am`;
 }
 
-const currentOutput = formatAs12HourClock("08:00");
-const targetOutput = "08:00 am";
-console.assert(
-  currentOutput === targetOutput,
-  `current output: ${currentOutput}, target output: ${targetOutput}`
-);
+// Tests:
+const tests = [
+  { input: "00:00", expected: "12:00 am" },
+  { input: "08:00", expected: "08:00 am" },
+  { input: "12:00", expected: "12:00 pm" },
+  { input: "15:30", expected: "3:30 pm" },
+  { input: "23:59", expected: "11:59 pm" },
+  { input: "11:15", expected: "11:15 am" },
+];
+
+tests.forEach(({ input, expected }) => {
+  const output = formatAs12HourClock(input);
+  console.assert(
+    output === expected,
+    `FAIL: input=${input}, output=${output}, expected=${expected}`
+  );
+});
 
-const currentOutput2 = formatAs12HourClock("23:00");
-const targetOutput2 = "11:00 pm";
-console.assert(
-  currentOutput2 === targetOutput2,
-  `current output: ${currentOutput2}, target output: ${targetOutput2}`
-);