fix: validate card ranks strictly and group tests by category

- Updated 3-get-card-value.js to reject invalid ranks like "0002♠", "0x02♠", and "2.1♠"
- Simplified logic with explicit checks for A, J, Q, K, 10, and digits 2–9
- Updated 3-get-card-value.test.js to group tests by categories:
  • Ace → returns 11
  • Number cards (2–10) → return their numeric value
  • Face cards (J, Q, K) → return 10
  • Invalid ranks → throw "Invalid card rank"

Author: HoussamLh

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

@@ -1,13 +1,16 @@
 function getCardValue(card) {
-  const rank = card.slice(0, -1); // All characters except the last one (suit)
+  const rank = card.slice(0, -1); // remove suit (last char)
 
   if (!rank) throw new Error("Invalid card rank");
 
   if (rank === "A") return 11;
-  if (["K", "Q", "J", "10"].includes(rank)) return 10;
+  if (["K", "Q", "J"].includes(rank)) return 10;
+  if (rank === "10") return 10;
 
-  const number = Number(rank);
-  if (number >= 2 && number <= 9) return number;
+  // Explicit check for number cards (2–9 only, no leading zeros or decimals)
+  if (/^[2-9]$/.test(rank)) {
+    return Number(rank);
+  }
 
   throw new Error("Invalid card rank");
 }

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

@@ -1,33 +1,36 @@
 const getCardValue = require("./3-get-card-value");
 
-test("should return 11 for Ace of Spades", () => {
+// Case 1: Ace
+test("should return 11 for Ace", () => {
   expect(getCardValue("A♠")).toEqual(11);
+  expect(getCardValue("A♥")).toEqual(11);
 });
 
-// Case 2: Handle Number Cards (2-10)
-test("should return 5 for Five of Hearts", () => {
-  expect(getCardValue("5♥")).toEqual(5);
-});
-
-test("should return 10 for Ten of Diamonds", () => {
-  expect(getCardValue("10♦")).toEqual(10);
-});
-
-// Case 3: Handle Face Cards (J, Q, K)
-test("should return 10 for Jack of Clubs", () => {
-  expect(getCardValue("J♣")).toEqual(10);
-});
+// Case 2: Number cards (2–10)
+test("should return the value of number cards (2–10)", () => {
+  expect(getCardValue("2♣")).toEqual(2);
+  expect(getCardValue("5♠")).toEqual(5);
+  expect(getCardValue("10♥")).toEqual(10);
 
-test("should return 10 for Queen of Spades", () => {
-  expect(getCardValue("Q♠")).toEqual(10);
+  // You can even loop for efficiency:
+  for (let i = 2; i <= 10; i++) {
+    expect(getCardValue(`${i}♦`)).toEqual(i);
+  }
 });
 
-test("should return 10 for King of Hearts", () => {
-  expect(getCardValue("K♥")).toEqual(10);
+// Case 3: Face cards (J, Q, K)
+test("should return 10 for face cards (J, Q, K)", () => {
+  ["J", "Q", "K"].forEach(rank => {
+    expect(getCardValue(`${rank}♠`)).toEqual(10);
+    expect(getCardValue(`${rank}♥`)).toEqual(10);
+  });
 });
 
-// Case 5: Handle Invalid Cards
+// Case 4: Invalid cards
 test("should throw an error for invalid card rank", () => {
   expect(() => getCardValue("Z♣")).toThrow("Invalid card rank");
+  expect(() => getCardValue("0x02♠")).toThrow("Invalid card rank");
+  expect(() => getCardValue("2.1♠")).toThrow("Invalid card rank");
+  expect(() => getCardValue("0002♠")).toThrow("Invalid card rank");
 });