London | SDC-Nov-25 | Emiliano Uruena | Sprint 3 | Implement Shell Tools#251
London | SDC-Nov-25 | Emiliano Uruena | Sprint 3 | Implement Shell Tools#251Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
…n a typical system: cat, ls, and wc.
Emilianouz
added
Needs Review
File doesn’t belong to this branch.
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on these tasks, I've left some comments for where it could be improved
There was a problem hiding this comment.
Did you mean to make changes to this file? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the sprint task directory.
| process.exit(1); | ||
| } | ||
|
|
||
| //const path = argv[0]; |
There was a problem hiding this comment.
We try to avoid comitting commented out code that is no longer needed
| .map((line,index) => `${(index + 1).toString().padStart(6)}\t${line}`) | ||
| .forEach(line => console.log(line)) | ||
|
|
||
| } else if (option.b){ |
There was a problem hiding this comment.
Try to be careful of indentation and formatting - can you spot the inconsistency here? You could consider using a formatting tool to help.
| import {program} from "commander"; | ||
| import { promises as fs } from "node:fs"; | ||
| import process from "node:process"; | ||
| import { glob } from "glob"; |
There was a problem hiding this comment.
When I try to run this file, i get this error: Cannot find package 'glob' . Can you figure out why?
LonMcGregor
added
Reviewed
2 participants
Self checklist
Changelist
Implementing common shell tools so that they behave like the real versions on a typical system: CAT, LS, WC. Node commander was installed to run in every directory.