London | 25-SDC-Nov | Jesus del Moral | Sprint 4 | Implement cowsay in Python #277
Open
delmorallopez wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | 25-SDC-Nov | Jesus del Moral | Sprint 4 | Implement cowsay in Python #277delmorallopez wants to merge 3 commits intoCodeYourFuture:mainfrom
delmorallopez wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
delmorallopez
force-pushed
the
implement-cowsay
branch
from
234f0a9 to
8eec635
Compare
delmorallopez
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Dec 23, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start. Some feedback:
- It is generally not a good idea to be reading library files directly like this. What if the library updates and changes where they are stored?
- You are missing a requirements file, so I can't run this unless I already know which library needs to be installed
LonMcGregor
added
Reviewed
Author
|
I’ve updated the script to use the cowsay public API instead of reading library files, and added a requirements.txt so the project is reproducible. |
delmorallopez
force-pushed
the
implement-cowsay
branch
2 times, most recently
from
f53e7d9 to
2a2c485
Compare
delmorallopez
force-pushed
the
implement-cowsay
branch
from
2a2c485 to
70d3155
Compare
delmorallopez
added
the
Needs Review
LonMcGregor
reviewed
Jan 6, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, this is almost complete. When you run it, do you see it printing the message "None" after the output is finished? can you figure out why that is happening and remove it?
LonMcGregor
removed
the
Needs Review
Author
|
animal_func(message) prints the cow/turtle, It returns None SOLUTION: animal_func(message) |
delmorallopez
added
the
Needs Review
|
Great work, this task is complete now |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Cowsay Library in Python
Write a command line tool which uses the cowsay library to show user-supplied text, as said by a specified animal.
Used the cowsay library, and not write down the list of supported animals yourself, just fetch this information from the library.