Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Edit] Lua - Tables #4791

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Edit] Lua - Tables #4791

wants to merge 4 commits into from

Conversation

ivaaane
Copy link
Contributor

@ivaaane ivaaane commented Jun 19, 2024 •
edited
Loading

Description

Added more information to the tables documentation of Lua, to explain about predefined table values and keys.

I consider tables are an essential aspect of Lua, so I considered the information used in the Docs isn't enough.

Issue Solved

Solves #4810

Type of Change

  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@ivaaane ivaaane changed the title Lua tables [Edit] Lua - Tables Jun 19, 2024
@ishg-153 ishg-153 self-assigned this Jun 19, 2024
@ishg-153 ishg-153 added enhancement New feature or request status: under review Issue or PR is currently being reviewed lua Lua entries labels Jun 19, 2024
@ishg-153
Copy link
Collaborator

@ivaaane Please remember for future contributions you must ask to be assigned to one of the available issues and once assigned you can create a PR for that issue.

For this PR I will create an issue and assign you.

ishg-153
ishg-153 requested changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivaaane Make these suggested changes.

content/lua/concepts/tables/tables.md Show resolved Hide resolved
@ishg-153 ishg-153 linked an issue Jun 21, 2024 that may be closed by this pull request
[Edit] Lua: Tables #4810
Open
3 tasks
@ivaaane
Copy link
Contributor Author

ivaaane commented Jun 21, 2024

@ishg-153 Sorry, it won't happen again :'D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishg-153 ishg-153 ishg-153 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ishg-153 ishg-153

Labels
enhancement New feature or request lua Lua entries status: review 1️⃣ completed status: waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] Lua: Tables
2 participants
@ivaaane @ishg-153