Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

images with spaces won't load #61

Open
ebbmo opened this issue Feb 21, 2015 · 2 comments
Open

images with spaces won't load #61

ebbmo opened this issue Feb 21, 2015 · 2 comments

Comments

@ebbmo
Copy link

ebbmo commented Feb 21, 2015

Hi Gilbitron,

I noticed an issue when implementing the slider - if an image in a folder contains a space, the image will not load. Removing the space in the file name solves the error.
This affects images inserted with the "data-src=" property - for "src=" it works (standard html).

Do you think you could fix that?

Thanks & kind regards,
ebbmo

@RomainSauvaire
Copy link

Hi @gilbitron common advice here is to avoid spaces in folders/filenames. Anyway I tested with spaces in filenames and it worked like a charm. Can you display the images without initializing them thought the slider ? BTW, what browser are you using... could be helpful for debug

@ebbmo
Copy link
Author

ebbmo commented Mar 2, 2015

Hi Romain,

I agree with your advice on avoiding spaces. My issue is that the slider
will display dynamically read pictures from a folder. And these pictures
will be updated regularly. So even though I will tell the user to avoid
spaces it might as well happen :/

I inserted the picuters without the slider - both display just fine
(with & without space).
I am using Chrome (Version 40.0.2214.115 (64-bit)

My setup is as follows:

  • index.php page which has a div for the slider (class slider)
  • then a js file which will read folder images (through a php file)
    and add these images to the slider
    o first picture containing src="path", second picture src="" and
    data-src="path"
  • after the images have been added, the slider will start with effect
    fade, transition 1200 and interval 4000. I also set the height.

In case you need my coding, let me know.

Kind regards,
ebbmo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants