Skip to content

Commit 182e0b9

Browse files
CodeneosCodeneos
committed
fix: update test cases to use getPackage() instead of build() for file retrieval
1 parent 53d9f7a commit 182e0b9

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

‎packages/salesforce/src/__tests__/salesforcePackageBuilder.test.ts‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe('SalesforcePackageBuilder', () => {
7474
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
7575
await packageBuilder.addFiles([ 'src/lwc/test/test.js-meta.xml']);
7676

77-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
77+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
7878
const manifest = packageBuilder.getManifest().toJson(apiVersion);
7979

8080
expect(filesAdded.length).toEqual(4);
@@ -93,7 +93,7 @@ describe('SalesforcePackageBuilder', () => {
9393
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
9494
await packageBuilder.addFiles([ 'src/lwc/test/test.html']);
9595

96-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
96+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
9797
const manifest = packageBuilder.getManifest().toJson(apiVersion);
9898

9999
expect(filesAdded.length).toEqual(4);
@@ -112,7 +112,7 @@ describe('SalesforcePackageBuilder', () => {
112112
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
113113
await packageBuilder.addFiles([ 'src/lwc/test/test.js']);
114114

115-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
115+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
116116
const manifest = packageBuilder.getManifest().toJson(apiVersion);
117117

118118
expect(filesAdded.length).toEqual(4);
@@ -131,7 +131,7 @@ describe('SalesforcePackageBuilder', () => {
131131
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
132132
await packageBuilder.addFiles([ 'src/lwc/test' ]);
133133

134-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
134+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
135135
const manifest = packageBuilder.getManifest().toJson(apiVersion);
136136

137137
expect(filesAdded.length).toEqual(4);
@@ -156,7 +156,7 @@ describe('SalesforcePackageBuilder', () => {
156156
'src/lwc/test/support.js'
157157
]);
158158

159-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
159+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
160160
const manifest = packageBuilder.getManifest().toJson(apiVersion);
161161

162162
expect(filesAdded.length).toEqual(4);
@@ -177,7 +177,7 @@ describe('SalesforcePackageBuilder', () => {
177177
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
178178
await packageBuilder.addFiles([ 'src/aura/test/test.cmp']);
179179

180-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
180+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
181181
const manifest = packageBuilder.getManifest().toJson(apiVersion);
182182

183183
expect(filesAdded.length).toEqual(3);
@@ -195,7 +195,7 @@ describe('SalesforcePackageBuilder', () => {
195195
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
196196
await packageBuilder.addFiles([ 'src/aura/test/testController.js']);
197197

198-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
198+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
199199
const manifest = packageBuilder.getManifest().toJson(apiVersion);
200200

201201
expect(filesAdded.length).toEqual(3);
@@ -213,7 +213,7 @@ describe('SalesforcePackageBuilder', () => {
213213
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
214214
await packageBuilder.addFiles([ 'src/aura/test' ]);
215215

216-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
216+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
217217
const manifest = packageBuilder.getManifest().toJson(apiVersion);
218218

219219
expect(filesAdded.length).toEqual(3);
@@ -233,7 +233,7 @@ describe('SalesforcePackageBuilder', () => {
233233
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
234234
await packageBuilder.addFiles([ 'src/classes/myClass.cls']);
235235

236-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
236+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
237237
const manifest = packageBuilder.getManifest().toJson(apiVersion);
238238

239239
expect(filesAdded.length).toEqual(2);
@@ -263,7 +263,7 @@ describe('SalesforcePackageBuilder', () => {
263263
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
264264
await packageBuilder.addFiles([ 'src/objects/PetersCustomObject__c']);
265265

266-
const sfPackage = await packageBuilder.build().generateArchive();
266+
const sfPackage = await packageBuilder.getPackage().generateArchive();
267267
const packageFiles = Object.keys(sfPackage.files);
268268
const metadata = await sfPackage.file('objects/PetersCustomObject__c.object')?.async('string');
269269
const parsedMetadata = metadata && XML.parse(metadata, { ignoreAttributes: true, ignoreNamespacePrefix: true });
@@ -291,7 +291,7 @@ describe('SalesforcePackageBuilder', () => {
291291
await packageBuilder.addFiles([ 'src/objects/PetersCustomObject__c/fields']);
292292

293293
const manifest = packageBuilder.getManifest().toJson(apiVersion);
294-
const sfPackage = await packageBuilder.build().generateArchive();
294+
const sfPackage = await packageBuilder.getPackage().generateArchive();
295295
const packageFiles = Object.keys(sfPackage.files);
296296
const metadata = await sfPackage.file('objects/PetersCustomObject__c.object')?.async('string');
297297
const parsedMetadata = metadata && XML.parse(metadata, { ignoreAttributes: true, ignoreNamespacePrefix: true });
@@ -331,7 +331,7 @@ describe('SalesforcePackageBuilder', () => {
331331
'main/default/app/settings/BusinessHours.settings'
332332
]);
333333

334-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
334+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
335335
const manifest = packageBuilder.getManifest().toJson(apiVersion);
336336

337337
expect(filesAdded.length).toEqual(3);
@@ -355,7 +355,7 @@ describe('SalesforcePackageBuilder', () => {
355355
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
356356
await packageBuilder.addFiles([ 'src/destructiveChangesPost.xml' ]);
357357

358-
const filesAdded = normalizePath(Object.keys((await packageBuilder.build().generateArchive()).files));
358+
const filesAdded = normalizePath(Object.keys((await packageBuilder.getPackage().generateArchive()).files));
359359
const manifest = packageBuilder.getManifest().toJson(apiVersion);
360360

361361
expect(filesAdded.length).toEqual(2); // includes package.xml
@@ -369,9 +369,9 @@ describe('SalesforcePackageBuilder', () => {
369369
'src/destructiveChangesPost2.xml'
370370
]);
371371

372-
const filesAdded = normalizePath(Object.keys((await packageBuilder.build().generateArchive()).files));
372+
const filesAdded = normalizePath(Object.keys((await packageBuilder.getPackage().generateArchive()).files));
373373
const manifest = packageBuilder.getManifest().toJson(apiVersion);
374-
const destructedClasses = packageBuilder.build().getDestructiveChanges();
374+
const destructedClasses = packageBuilder.getPackage().getDestructiveChanges();
375375

376376
expect(destructedClasses).toEqual([
377377
{
@@ -402,9 +402,9 @@ describe('SalesforcePackageBuilder', () => {
402402
'src/destructiveChanges.xml'
403403
]);
404404

405-
const filesAdded = normalizePath(Object.keys((await packageBuilder.build().generateArchive()).files));
405+
const filesAdded = normalizePath(Object.keys((await packageBuilder.getPackage().generateArchive()).files));
406406
const manifest = packageBuilder.getManifest().toJson(apiVersion);
407-
const destructedClasses = packageBuilder.build().getDestructiveChanges();
407+
const destructedClasses = packageBuilder.getPackage().getDestructiveChanges();
408408

409409
expect(filesAdded.length).toEqual(2);
410410
expect(destructedClasses).toEqual([
@@ -429,7 +429,7 @@ describe('SalesforcePackageBuilder', () => {
429429
'src/destructiveChangesPost.xml'
430430
]);
431431

432-
const filesAdded = normalizePath(Object.keys((await packageBuilder.build().generateArchive()).files));
432+
const filesAdded = normalizePath(Object.keys((await packageBuilder.getPackage().generateArchive()).files));
433433
const manifest = packageBuilder.getManifest().toJson(apiVersion);
434434

435435
expect(filesAdded.length).toEqual(3);
@@ -445,9 +445,9 @@ describe('SalesforcePackageBuilder', () => {
445445
'src/destructiveChangesSingle.xml'
446446
]);
447447

448-
const filesAdded = normalizePath(Object.keys((await packageBuilder.build().generateArchive()).files));
448+
const filesAdded = normalizePath(Object.keys((await packageBuilder.getPackage().generateArchive()).files));
449449
const manifest = packageBuilder.getManifest().toJson(apiVersion);
450-
const destructedClasses = packageBuilder.build().getDestructiveChanges();
450+
const destructedClasses = packageBuilder.getPackage().getDestructiveChanges();
451451
expect(destructedClasses).toEqual([
452452
{
453453
componentName: 'a',
@@ -467,7 +467,7 @@ describe('SalesforcePackageBuilder', () => {
467467
const packageBuilder = new SalesforcePackageBuilder(SalesforcePackageType.deploy, apiVersion, mockFs);
468468
await packageBuilder.addFiles([ 'src' ]);
469469

470-
const filesAdded = normalizePath([...packageBuilder.build().files()]);
470+
const filesAdded = normalizePath([...packageBuilder.getPackage().files()]);
471471
const manifest = packageBuilder.getManifest();
472472

473473
expect(filesAdded).toEqual(expect.arrayContaining([
@@ -493,7 +493,7 @@ describe('SalesforcePackageBuilder', () => {
493493
await packageBuilder.addFiles([ 'src/dashboards' ]);
494494

495495
const manifest = packageBuilder.getManifest();
496-
const [ folder, dashBoard ] = [...packageBuilder.build().sourceFiles()]
496+
const [ folder, dashBoard ] = [...packageBuilder.getPackage().sourceFiles()]
497497
.sort((a,b) => a.packagePath.localeCompare(b.packagePath));
498498

499499
expect(folder.packagePath).toEqual('dashboards/MyFolder-meta.xml');
@@ -512,7 +512,7 @@ describe('SalesforcePackageBuilder', () => {
512512
});
513513
await packageBuilder.addFiles([ 'src' ]);
514514

515-
const buildPackage = packageBuilder.build();
515+
const buildPackage = await packageBuilder.getPackage();
516516
const classMetaXml = buildPackage.getPackageData('classes/myClass.cls-meta.xml')?.data?.toString();
517517
const triggeretaXml = buildPackage.getPackageData('triggers/myTrigger.trigger-meta.xml')?.data?.toString();
518518

@@ -529,7 +529,7 @@ describe('SalesforcePackageBuilder', () => {
529529
});
530530
await packageBuilder.addFiles([ 'src' ]);
531531

532-
const buildPackage = packageBuilder.build();
532+
const buildPackage = await packageBuilder.getPackage();
533533
const classMetaXml = buildPackage.getPackageData('classes/myClass.cls-meta.xml')?.data?.toString();
534534
const triggeretaXml = buildPackage.getPackageData('triggers/myTrigger.trigger-meta.xml')?.data?.toString();
535535

0 commit comments

Comments
 (0)