Skip to content

Commit a7e4a7a

Browse files
committed
chore: update lerna and fix eslint issues
1 parent 91feb2b commit a7e4a7a

File tree

12 files changed

+1281
-140
lines changed

12 files changed

+1281
-140
lines changed

.eslintrc.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@ module.exports = {
4646
"@typescript-eslint/no-non-null-assertion": 0,
4747
"@typescript-eslint/ban-ts-comment": 0,
4848
"@typescript-eslint/no-namespace": 0,
49-
"@typescript-eslint/ban-types": [
50-
"error", {
51-
"types": {
52-
"Object": false
53-
},
54-
"extendDefaults": true
55-
}
56-
],
5749
"no-cond-assign": 1,
5850
"prefer-spread": 1,
5951
"no-unused-vars": "off",

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
},
2222
"devDependencies": {
2323
"@lerna-lite/cli": "^3.8.0",
24+
"@lerna-lite/publish": "^3.8.0",
25+
"@lerna-lite/version": "^3.8.0",
2426
"@types/fs-extra": "^11",
2527
"@types/jest": "^29.5.11",
2628
"@types/node": "^20",
@@ -111,7 +113,7 @@
111113
"sync-ws-version": "node -e \"fs.writeFileSync('./package.json', JSON.stringify({ ...require('./package.json'), version: require('./lerna.json').version }, undefined, 4));\"",
112114
"test": "jest",
113115
"prepare": "husky install",
114-
"lint": "eslint ./packages/*/src/**/*.ts --no-error-on-unmatched-pattern",
116+
"lint": "eslint ./packages/*/src --no-error-on-unmatched-pattern",
115117
"docs": "pnpm sync-ws-version && typedoc"
116118
},
117119
"resolutions": {

packages/core/src/container.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ export class Container {
411411
* @param serviceGuid the instance guid of the object that owns the dependency
412412
* @param dependsOn instance of the dependency
413413
*/
414-
private trackServiceDependencies(serviceGuid: string, dependsOn: Object) {
414+
private trackServiceDependencies(serviceGuid: string, dependsOn: object) {
415415
const dependencyGuid = dependsOn[ServiceGuidSymbol];
416416
if (isServiceProxy(dependsOn) && !dependsOn[serviceIsResolved]) {
417417
dependsOn[proxyTarget].once('resolved', instance => this.trackServiceDependencies(serviceGuid, instance));

packages/core/src/inject.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export const injectable = Object.assign(function injectable<T extends { new(...a
8787
* @returns
8888
*/
8989
param: function (serviceType: ServiceType) {
90-
return function(target: Object, propertyKey: undefined, parameterIndex: number) {
90+
return function(target: object, propertyKey: undefined, parameterIndex: number) {
9191
const serviceName = typeof serviceType === 'string' ? serviceType : (serviceType.prototype?.constructor?.name ?? serviceType.name);
9292
Reflect.defineMetadata(`dependency:inject:${parameterIndex}`, serviceName, target);
9393
};
@@ -108,6 +108,6 @@ export const injectable = Object.assign(function injectable<T extends { new(...a
108108
* @param propertyKey
109109
* @param parameterIndex
110110
*/
111-
export function ignore(target: Object, propertyKey: string | symbol, parameterIndex: number) {
111+
export function ignore(target: object, propertyKey: string | symbol, parameterIndex: number) {
112112
Reflect.defineMetadata(`dependency:inject:${parameterIndex}:ignore`, true, target);
113113
}

packages/core/src/serviceProxy.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export interface ServiceProxy<T extends object = object> {
2222
* @param prototype Prototype of the service instance
2323
* @returns Service proxy
2424
*/
25-
export function createServiceProxy<T extends Object>(factory: () => T, prototype: any) : ServiceProxy<T> & T {
25+
export function createServiceProxy<T extends object>(factory: () => T, prototype: any) : ServiceProxy<T> & T {
2626
return new Proxy(new ProxyTarget(factory), {
2727
get(target, prop) {
2828
if (prop === serviceProxyMarker) {
@@ -83,8 +83,8 @@ export function isServiceProxy(obj: unknown) : obj is ServiceProxy {
8383
* Allows for listening to the resolved event before the service instance is created.
8484
* The service instance can be set using the setInstance method which will override the existing instance.
8585
*/
86-
export class ProxyTarget<T extends Object> extends EventEmitter {
87-
public instance?: T & Object;
86+
export class ProxyTarget<T extends object> extends EventEmitter {
87+
public instance?: T & object;
8888
private static supportedEvents: (symbol | string)[] = [ 'resolved' ];
8989

9090
constructor(private readonly factory: () => T) {

packages/util/src/defaults.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export function withDefaults<T extends object, D extends T>(obj: T | undefined,
1616
}
1717
}
1818
if (typeof value === 'object' && defaultValues[prop]) {
19-
return withDefaults<Object, Object>(value, defaultValues[prop]);
19+
return withDefaults<object, object>(value, defaultValues[prop]);
2020
}
2121
return value;
2222
},

packages/util/src/observer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export interface PropertyChangedEventArgs {
99
oldValue?: any;
1010
}
1111

12-
export type Observable<T extends Object> = T & { onPropertyChanged: vscodeModule.Event<PropertyChangedEventArgs> } & vscodeModule.Disposable;
12+
export type Observable<T extends object> = T & { onPropertyChanged: vscodeModule.Event<PropertyChangedEventArgs> } & vscodeModule.Disposable;
1313

1414
export interface ArrayChangedEventArgs<T> {
1515
type: 'add' | 'remove' | 'replace';
@@ -24,7 +24,7 @@ export type ObservableArray<T> = Array<T> & { onArrayChanged: vscodeModule.Event
2424
* Creates an observer that watches all properties in the target objects, when ever a change is detected it fires the change event triggers
2525
* @param obj
2626
*/
27-
export function observeObject<T extends Object>(obj: T) : Observable<T> {
27+
export function observeObject<T extends object>(obj: T) : Observable<T> {
2828
const eventEmitter = new vscode.EventEmitter<PropertyChangedEventArgs>();
2929
return new Proxy(obj, {
3030
get(target, property) {

packages/util/src/salesforce.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { cacheFunction } from './cache';
55
* Create a record proxy around a SF record removing any namespace prefixes it may contain and making all fields accessible with case-insensitive keys.
66
* @param record SF Like record object
77
*/
8-
export function createRecordProxy<T extends Object>(record: T, writable: boolean = false) : T & { [key: string] : any } {
8+
export function createRecordProxy<T extends object>(record: T, writable: boolean = false) : T & { [key: string] : any } {
99
const getPropertyKey = (target: T, name: string | number | symbol) => Object.keys(target).find(key => {
1010
return stringEquals(key, name.toString(), true) || stringEquals(removeNamespacePrefix(key), name.toString(), true);
1111
});

packages/util/src/validate.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ import 'reflect-metadata';
33

44
export const RequiredMetadataKey = Symbol('[[ValidateRequiredParams]]');
55

6-
// eslint-disable-next-line @typescript-eslint/ban-types
7-
export const validate = Object.assign(function (target: any, propertyKey: string, descriptor: TypedPropertyDescriptor<Function>) {
6+
export const validate = Object.assign(function (target: any, propertyKey: string, descriptor: TypedPropertyDescriptor<(...args: any[]) => any>) {
87
const originalMethod = descriptor.value!;
98

109
descriptor.value = function (...args: unknown[]) {
@@ -17,7 +16,7 @@ export const validate = Object.assign(function (target: any, propertyKey: string
1716
return originalMethod.apply(this, args);
1817
};
1918
}, {
20-
required: function(target: Object, propertyKey: string | symbol, parameterIndex: number) {
19+
required: function(target: object, propertyKey: string | symbol, parameterIndex: number) {
2120
const requiredParameters: number[] = Reflect.getOwnMetadata(RequiredMetadataKey, target, propertyKey) || [];
2221
requiredParameters.push(parameterIndex);
2322
Reflect.defineMetadata(RequiredMetadataKey, requiredParameters, target, propertyKey);

0 commit comments

Comments
 (0)