Skip to content

Commit c436e81

Browse files
committed
fix: API 64.0 does not properly print deployment results
1 parent aab9f12 commit c436e81

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

packages/salesforce/src/connection/metadata/types/deployResult.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ export interface DeployResult {
4747
export interface DeployResultDetails {
4848
componentFailures: Array<FailureDeployMessage>;
4949
componentSuccesses: Array<DeployMessage>;
50+
/**
51+
* @deprecated From API 64.0 allComponentMessages is not included in the response any more.
52+
*/
5053
allComponentMessages: Array<DeployMessage | FailureDeployMessage>;
5154
runTestResult: RunTestsResult
5255
}

packages/salesforce/src/salesforceDeployment.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,12 @@ export class SalesforceDeployment extends AsyncEventEmitter<SalesforceDeployment
286286
details.componentFailures = details.componentFailures?.filter(failure => !this.isDependentClassError(failure));
287287
details.allComponentMessages = details.allComponentMessages?.filter(msg => !('problemType' in msg) || !this.isDependentClassError(msg));
288288

289+
if (!details.allComponentMessages) {
290+
details.allComponentMessages = [];
291+
details.componentFailures && details.allComponentMessages.push(details.componentFailures);
292+
details.componentSuccesses && details.allComponentMessages.push(details.componentSuccesses);
293+
}
294+
289295
if (details.runTestResult?.failures) {
290296
details.runTestResult.failures = details.runTestResult?.failures?.filter(
291297
failure => failure.message.includes('Dependent class is invalid')

packages/vscode-extension/src/commands/metadata/metadataCommand.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default abstract class MetadataCommand extends CommandBase {
3535
}
3636

3737
protected outputDeployResult(components: SalesforcePackageComponent[], result: DeployResult) {
38-
const deployMessages = mapBy(result.details?.allComponentMessages || [], message => `${message.componentType}/${message.fullName}`);
38+
const deployMessages = mapBy(result.details?.allComponentMessages ?? [], message => `${message.componentType}/${message.fullName}`);
3939
const deployComponentStatus = components.map(
4040
component => {
4141
const message = deployMessages.get(`${component.componentType}/${component.componentName}`);

0 commit comments

Comments
 (0)