Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funkcja checkWin w nieodpowiednim miejscu #8

Open
Bravo555 opened this issue Nov 7, 2015 · 0 comments
Open

Funkcja checkWin w nieodpowiednim miejscu #8

Bravo555 opened this issue Nov 7, 2015 · 0 comments

Comments

@Bravo555
Copy link
Contributor

Bravo555 commented Nov 7, 2015

Zauważyłem, że funkcja checkWin jest prawie taka sama dla każdego gracza, a jedyne czym się różni to wartość do której porównywana jest zawartość pola.

  • Dla PlayerGreen
virtual bool checkWin(int board[3][3])
    {
        if(((board[0][0] == 1) && (board[0][1] == 1) && (board[0][2] == 1)) ||
           ((board[1][0] == 1) && (board[1][1] == 1) && (board[1][2] == 1)) ||
           ((board[2][0] == 1) && (board[2][1] == 1) && (board[2][2] == 1)) ||
           ((board[0][0] == 1) && (board[1][0] == 1) && (board[2][0] == 1)) ||
           ((board[0][1] == 1) && (board[1][1] == 1) && (board[2][1] == 1)) ||
           ((board[0][2] == 1) && (board[1][2] == 1) && (board[2][2] == 1)) ||
           ((board[0][0] == 1) && (board[1][1] == 1) && (board[2][2] == 1)) ||
           ((board[2][0] == 1) && (board[1][1] == 1) && (board[0][2] == 1)))
        {
            return true;
        }
        else
            return false;
    }
  • dla PlayerBlue
virtual bool checkWin(int board[3][3])
    {
        if(((board[0][0] == 2) && (board[0][1] == 2) && (board[0][2] == 2)) ||
           ((board[1][0] == 2) && (board[1][1] == 2) && (board[1][2] == 2)) ||
           ((board[2][0] == 2) && (board[2][1] == 2) && (board[2][2] == 2)) ||
           ((board[0][0] == 2) && (board[1][0] == 2) && (board[2][0] == 2)) ||
           ((board[0][1] == 2) && (board[1][1] == 2) && (board[2][1] == 2)) ||
           ((board[0][2] == 2) && (board[1][2] == 2) && (board[2][2] == 2)) ||
           ((board[0][0] == 2) && (board[1][1] == 2) && (board[2][2] == 2)) ||
           ((board[2][0] == 2) && (board[1][1] == 2) && (board[0][2] == 2)))
        {
            return true;
        }
        else
            return false;
    }

Jak widać funkcje są prawie takie same, moim zdaniem należałoby je przenieść gdzieś do klasy Game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant