From 44413841da80e31952092bbfec7760a4b7a5efcd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= Date: Tue, 13 Feb 2024 19:48:05 +0100 Subject: [PATCH] fix: remove useless service override the title service override does override the window title --- package-lock.json | 42 ++++++++++++++++++------------------------ package.json | 2 -- src/features/views.ts | 4 ---- 3 files changed, 18 insertions(+), 30 deletions(-) diff --git a/package-lock.json b/package-lock.json index 87260ce..cfa4dca 100644 --- a/package-lock.json +++ b/package-lock.json @@ -74,9 +74,7 @@ "@codingame/monaco-vscode-timeline-service-override": "^2.1.4", "@codingame/monaco-vscode-typescript-basics-default-extension": "^2.1.3", "@codingame/monaco-vscode-vb-default-extension": "^2.1.3", - "@codingame/monaco-vscode-view-banner-service-override": "^2.1.4", "@codingame/monaco-vscode-view-status-bar-service-override": "^2.1.3", - "@codingame/monaco-vscode-view-title-bar-service-override": "^2.1.4", "@codingame/monaco-vscode-views-service-override": "^2.1.3", "@codingame/monaco-vscode-working-copy-service-override": "^2.1.3", "@codingame/monaco-vscode-xml-default-extension": "^2.1.3", @@ -952,15 +950,6 @@ "vscode": "npm:@codingame/monaco-vscode-api@2.1.4" } }, - "node_modules/@codingame/monaco-vscode-view-banner-service-override": { - "version": "2.1.4", - "resolved": "https://registry.npmjs.org/@codingame/monaco-vscode-view-banner-service-override/-/monaco-vscode-view-banner-service-override-2.1.4.tgz", - "integrity": "sha512-NHDf4W+6ZXp/XwFqJvMNmH6tTuNQZzq0aUjuumZFJd6iW+Q1gmHl5nKEaD0NugXzoGWbUzKejItsYjbBOQn4bw==", - "dependencies": { - "vscode": "npm:@codingame/monaco-vscode-api@2.1.4", - "vscode-marked": "npm:marked@=3.0.2" - } - }, "node_modules/@codingame/monaco-vscode-view-status-bar-service-override": { "version": "2.1.4", "resolved": "https://registry.npmjs.org/@codingame/monaco-vscode-view-status-bar-service-override/-/monaco-vscode-view-status-bar-service-override-2.1.4.tgz", @@ -969,15 +958,6 @@ "vscode": "npm:@codingame/monaco-vscode-api@2.1.4" } }, - "node_modules/@codingame/monaco-vscode-view-title-bar-service-override": { - "version": "2.1.4", - "resolved": "https://registry.npmjs.org/@codingame/monaco-vscode-view-title-bar-service-override/-/monaco-vscode-view-title-bar-service-override-2.1.4.tgz", - "integrity": "sha512-t6hkmXJjzKYQWxsC4a3UFdoNpmEX64NUCo0s0cOR/jniYGyH4PnhdT6ij/y1BVPk9JDa4I4o//mHmSzUGxNmqw==", - "dependencies": { - "vscode": "npm:@codingame/monaco-vscode-api@2.1.4", - "vscode-marked": "npm:marked@=3.0.2" - } - }, "node_modules/@codingame/monaco-vscode-views-service-override": { "version": "2.1.4", "resolved": "https://registry.npmjs.org/@codingame/monaco-vscode-views-service-override/-/monaco-vscode-views-service-override-2.1.4.tgz", @@ -1050,6 +1030,7 @@ "resolved": "https://registry.npmjs.org/@colors/colors/-/colors-1.5.0.tgz", "integrity": "sha512-ooWCrlZP11i8GImSjTHYHLkvFDP48nS4+204nGb1RiX/WXYHmJA2III9/e2DWVabCESdW7hBAEzHRqUn9OUVvQ==", "optional": true, + "peer": true, "engines": { "node": ">=0.1.90" } @@ -3126,7 +3107,8 @@ "node_modules/balanced-match": { "version": "1.0.2", "resolved": "https://registry.npmjs.org/balanced-match/-/balanced-match-1.0.2.tgz", - "integrity": "sha512-3oSeUO0TMV67hN1AmbXsK4yaqU7tjiHlbxRDZOpH0KW9+CeX4bRAaX0Anxt0tx2MrpRpWwQaPwIlISEJhYU5Pw==" + "integrity": "sha512-3oSeUO0TMV67hN1AmbXsK4yaqU7tjiHlbxRDZOpH0KW9+CeX4bRAaX0Anxt0tx2MrpRpWwQaPwIlISEJhYU5Pw==", + "dev": true }, "node_modules/base64-js": { "version": "1.5.1", @@ -3208,6 +3190,7 @@ "version": "2.0.1", "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz", "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==", + "dev": true, "dependencies": { "balanced-match": "^1.0.0" } @@ -3645,6 +3628,7 @@ "version": "0.6.3", "resolved": "https://registry.npmjs.org/cli-table3/-/cli-table3-0.6.3.tgz", "integrity": "sha512-w5Jac5SykAeZJKntOxJCrm63Eg5/4dhMWIcuTbo9rpE+brgaSZo0RuNJZeOyMgsUdhDeojvgyQLmjI+K50ZGyg==", + "peer": true, "dependencies": { "string-width": "^4.2.0" }, @@ -5624,7 +5608,8 @@ "node_modules/fs.realpath": { "version": "1.0.0", "resolved": "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz", - "integrity": "sha512-OO0pH2lK6a0hZnAdau5ItzHPI6pUlvI7jMVnxUQRtw4owF2wk8lOSabtGDCTP4Ggrg2MbGnWO9X8K1t4+fGMDw==" + "integrity": "sha512-OO0pH2lK6a0hZnAdau5ItzHPI6pUlvI7jMVnxUQRtw4owF2wk8lOSabtGDCTP4Ggrg2MbGnWO9X8K1t4+fGMDw==", + "dev": true }, "node_modules/fsevents": { "version": "2.3.3", @@ -6061,6 +6046,7 @@ "version": "8.1.0", "resolved": "https://registry.npmjs.org/glob/-/glob-8.1.0.tgz", "integrity": "sha512-r8hpEjiQEYlF2QU0df3dS+nxxSIreXQS1qRhMJM0Q5NDdR386C7jb7Hwwod8Fgiuex+k0GFjgft18yvxm5XoCQ==", + "dev": true, "dependencies": { "fs.realpath": "^1.0.0", "inflight": "^1.0.4", @@ -6091,6 +6077,7 @@ "version": "5.1.6", "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-5.1.6.tgz", "integrity": "sha512-lKwV/1brpG6mBUFHtb7NUmtABCb2WZZmm2wNiOA5hAb8VdCS4B3dtMWyvcoViccwAW/COERjXLt0zP1zXUN26g==", + "dev": true, "dependencies": { "brace-expansion": "^2.0.1" }, @@ -6412,6 +6399,7 @@ "version": "4.1.0", "resolved": "https://registry.npmjs.org/hosted-git-info/-/hosted-git-info-4.1.0.tgz", "integrity": "sha512-kyCuEOWjJqZuDbRHzL8V93NzQhwIB71oFWSyzVo+KPZI+pnQPPxucdkrOZvkLRnrf5URsQM+IJ09Dw29cRALIA==", + "dev": true, "dependencies": { "lru-cache": "^6.0.0" }, @@ -6600,6 +6588,7 @@ "version": "1.0.6", "resolved": "https://registry.npmjs.org/inflight/-/inflight-1.0.6.tgz", "integrity": "sha512-k92I/b08q4wvFscXCLvqfsHCrjrF7yiXsQuIVvVE7N82W3+aqpzuUdBbfhWcy/FZR3/4IgflMgKLOsvPDrGCJA==", + "dev": true, "dependencies": { "once": "^1.3.0", "wrappy": "1" @@ -6614,6 +6603,7 @@ "version": "4.1.1", "resolved": "https://registry.npmjs.org/ini/-/ini-4.1.1.tgz", "integrity": "sha512-QQnnxNyfvmHFIsj7gkPcYymR8Jdw/o7mp5ZFihxn6h8Ci6fh3Dx4E1gPjpQEpIuPo9XVNY/ZUwh4BPMjGyL01g==", + "dev": true, "engines": { "node": "^14.17.0 || ^16.13.0 || >=18.0.0" } @@ -7980,6 +7970,7 @@ "version": "9.0.3", "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-9.0.3.tgz", "integrity": "sha512-RHiac9mvaRw0x3AYRgDC1CxAP7HTcNrrECeA8YYJeWnpo+2Q5CegtZjaotWTWxDG3UeGA1coE05iH1mPjT/2mg==", + "dev": true, "dependencies": { "brace-expansion": "^2.0.1" }, @@ -8058,7 +8049,8 @@ "node_modules/mute-stream": { "version": "0.0.8", "resolved": "https://registry.npmjs.org/mute-stream/-/mute-stream-0.0.8.tgz", - "integrity": "sha512-nnbWWOkoWyUsTjKrhgD0dcz22mdkSnpYqbEjIm2nhwhuxlSkpywJmBo8h0ZqJdkp73mb90SssHkN4rsRaBAfAA==" + "integrity": "sha512-nnbWWOkoWyUsTjKrhgD0dcz22mdkSnpYqbEjIm2nhwhuxlSkpywJmBo8h0ZqJdkp73mb90SssHkN4rsRaBAfAA==", + "dev": true }, "node_modules/mz": { "version": "2.7.0", @@ -11503,6 +11495,7 @@ "version": "1.0.7", "resolved": "https://registry.npmjs.org/read/-/read-1.0.7.tgz", "integrity": "sha512-rSOKNYUmaxy0om1BNjMN4ezNT6VKK+2xF4GBhc81mkH7L60i6dp8qPYrkndNLT3QPphoII3maL9PVC9XmhHwVQ==", + "dev": true, "dependencies": { "mute-stream": "~0.0.4" }, @@ -12859,7 +12852,8 @@ "node_modules/text-table": { "version": "0.2.0", "resolved": "https://registry.npmjs.org/text-table/-/text-table-0.2.0.tgz", - "integrity": "sha512-N+8UisAXDGk8PFXP4HAzVR9nbfmVJ3zYLAWiTIoqC5v5isinhr+r5uaO8+7r3BMfuNIufIsA7RdpVgacC2cSpw==" + "integrity": "sha512-N+8UisAXDGk8PFXP4HAzVR9nbfmVJ3zYLAWiTIoqC5v5isinhr+r5uaO8+7r3BMfuNIufIsA7RdpVgacC2cSpw==", + "dev": true }, "node_modules/thenify": { "version": "3.3.1", diff --git a/package.json b/package.json index 74f71f4..a855285 100644 --- a/package.json +++ b/package.json @@ -149,9 +149,7 @@ "@codingame/monaco-vscode-timeline-service-override": "^2.1.4", "@codingame/monaco-vscode-typescript-basics-default-extension": "^2.1.3", "@codingame/monaco-vscode-vb-default-extension": "^2.1.3", - "@codingame/monaco-vscode-view-banner-service-override": "^2.1.4", "@codingame/monaco-vscode-view-status-bar-service-override": "^2.1.3", - "@codingame/monaco-vscode-view-title-bar-service-override": "^2.1.4", "@codingame/monaco-vscode-views-service-override": "^2.1.3", "@codingame/monaco-vscode-working-copy-service-override": "^2.1.3", "@codingame/monaco-vscode-xml-default-extension": "^2.1.3", diff --git a/src/features/views.ts b/src/features/views.ts index b4e52e0..39e1b54 100644 --- a/src/features/views.ts +++ b/src/features/views.ts @@ -1,8 +1,6 @@ import getViewsServiceOverride from '@codingame/monaco-vscode-views-service-override' import getStatusBarServiceOverride from '@codingame/monaco-vscode-view-status-bar-service-override' -import getTitleBarServiceOverride from '@codingame/monaco-vscode-view-title-bar-service-override' import getQuickAccessServiceOverride from '@codingame/monaco-vscode-quickaccess-service-override' -import getBannerServiceOverride from '@codingame/monaco-vscode-view-banner-service-override' import { editorOpenHandlerRegistry, registerServices, useGlobalPicker } from '../services' import '@codingame/monaco-vscode-theme-seti-default-extension' @@ -16,8 +14,6 @@ registerServices({ return editorOpenHandlerRegistry.openCodeEditor(model, input, sideBySide) }), ...getStatusBarServiceOverride(), - ...getTitleBarServiceOverride(), - ...getBannerServiceOverride(), ...getQuickAccessServiceOverride({ shouldUseGlobalPicker () { return useGlobalPicker()