Skip to content

Commit d10363c

Browse files
authored
Merge pull request #113 from CodinGame/fix-placeholder
Fix placeholder update when model changes
2 parents 910edd4 + 591fc73 commit d10363c

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/tools.ts

+7-4
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,8 @@ export function addPlaceholder (
464464
editor: monaco.editor.ICodeEditor,
465465
placeholder: string
466466
): monaco.IDisposable {
467+
const disposableStore = new DisposableStore()
468+
467469
const widget = new PlaceholderContentWidget(editor, placeholder)
468470

469471
function onDidChangeModelContent (): void {
@@ -475,13 +477,14 @@ export function addPlaceholder (
475477
}
476478

477479
onDidChangeModelContent()
478-
const changeDisposable = editor.onDidChangeModelContent(() => onDidChangeModelContent())
479-
return {
480+
disposableStore.add(editor.onDidChangeModelContent(onDidChangeModelContent))
481+
disposableStore.add(editor.onDidChangeModel(onDidChangeModelContent))
482+
disposableStore.add({
480483
dispose () {
481-
changeDisposable.dispose()
482484
editor.removeContentWidget(widget)
483485
}
484-
}
486+
})
487+
return disposableStore
485488
}
486489

487490
export function mapClipboard (

0 commit comments

Comments
 (0)