Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview link in passenger showcase guide #702

Open
DenisovichDev opened this issue Oct 21, 2022 · 9 comments
Open

Preview link in passenger showcase guide #702

DenisovichDev opened this issue Oct 21, 2022 · 9 comments
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@DenisovichDev
Copy link
Member

Under SUBMITTING A PULL REQUEST I think it's worth mentioning that in the description of the PR it's good to have a preview link. Since we don't have that template thing like we did in the old repo anymore.

I think this screenshot could have a preview link or picture:
image

@DenisovichDev DenisovichDev added the documentation Improvements or additions to documentation label Oct 21, 2022
@shiffman
Copy link
Member

Good call! I'm also not opposed to adding templates for issues and pull requests if you have ideas on what would be most helpful to the community!

@DenisovichDev
Copy link
Member Author

@shiffman I can work on some templates for PR and issues if you like! I think something minimal would be the best.
I'll get working on the edits to be made in the guide for now then.

@shiffman
Copy link
Member

Sounds great! The reason I am slow to do this one and #628 is changing the screenshots maybe requires doing all of them so that they have the same look and feel?

@DenisovichDev
Copy link
Member Author

Yes I have that in my mind. I can try make it look similar with a bit of editing. And if it doesn't look very good at the end, we can keep it in hold while we get the screenshots ready for it. There's no rush anyway

@dipamsen
Copy link
Member

For PR Templates, I think the following versions are possible:

  • Porting a Track
  • Porting a Challenge
  • Showcase Submission

@shiffman
Copy link
Member

Agreed! This is a tiny point but I think we can consider them "Creating a Track" or "Creating a Challenge Page" since it ultimately is less about porting and more about making the content for the site! Also, we are close to getting all of the older challenges done so I'm not sure how much longer that will be relevant! (There are probably so many ways that side tracks can be configured).

@dipamsen
Copy link
Member

That is true!

@DenisovichDev
Copy link
Member Author

Ah thank you @dipamsen!

@DenisovichDev DenisovichDev self-assigned this Oct 27, 2022
@shiffman shiffman added the help wanted Extra attention is needed label Mar 19, 2024
@shiffman
Copy link
Member

shiffman commented Dec 2, 2024

Is this still a valid issue? It's been 2 years now so I'm not sure if it's still relevant given where we are with the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants