-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview link in passenger showcase guide #702
Comments
Good call! I'm also not opposed to adding templates for issues and pull requests if you have ideas on what would be most helpful to the community! |
@shiffman I can work on some templates for PR and issues if you like! I think something minimal would be the best. |
Sounds great! The reason I am slow to do this one and #628 is changing the screenshots maybe requires doing all of them so that they have the same look and feel? |
Yes I have that in my mind. I can try make it look similar with a bit of editing. And if it doesn't look very good at the end, we can keep it in hold while we get the screenshots ready for it. There's no rush anyway |
For PR Templates, I think the following versions are possible:
|
Agreed! This is a tiny point but I think we can consider them "Creating a Track" or "Creating a Challenge Page" since it ultimately is less about porting and more about making the content for the site! Also, we are close to getting all of the older challenges done so I'm not sure how much longer that will be relevant! (There are probably so many ways that side tracks can be configured). |
That is true! |
Ah thank you @dipamsen! |
Is this still a valid issue? It's been 2 years now so I'm not sure if it's still relevant given where we are with the repo? |
Under SUBMITTING A PULL REQUEST I think it's worth mentioning that in the description of the PR it's good to have a preview link. Since we don't have that template thing like we did in the old repo anymore.
I think this screenshot could have a preview link or picture:
The text was updated successfully, but these errors were encountered: