Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images with Tags I.e. not the "latest" are updated frequently #35

Open
Nanoemc opened this issue Oct 8, 2024 · 4 comments
Open

Images with Tags I.e. not the "latest" are updated frequently #35

Nanoemc opened this issue Oct 8, 2024 · 4 comments

Comments

@Nanoemc
Copy link

Nanoemc commented Oct 8, 2024

Some of the 0.7 images (I.e. coffea-base-almalinux8
) and coffea 2024 images (I.e. coffea-dask-almalinux8) have their package versions updated at the same frequency as the latest images. It causes issues with analysis pipelines and with the EAF, maybe there should be a latest-2024-py3.x tag and a latest-0.7.22-py3.x tag to avoid this in the future. It is hard to have a stable pipeline when some of the tagged images (not latest) are changing.

@nsmith-
Copy link
Member

nsmith- commented Oct 16, 2024

So, concretely, we do have what I would call a bug in the github action: when we bump a version of coffea-dask (i.e. coffea CalVer) we re-render also the coffea-base image, which may cause some unpinned versions to be updated and potentially break if the tests do not catch issues. For example, when #33 was merged the CI pushed a new image overwriting the tag coffea-base-almalinux8:0.7.22-py3.10: https://github.com/CoffeaTeam/af-images/actions/runs/11013386721/job/30581631518
We probably want all tags but latest to be permanent.

oshadura added a commit to oshadura/af-images that referenced this issue Oct 17, 2024
oshadura added a commit to oshadura/af-images that referenced this issue Oct 17, 2024
oshadura added a commit to oshadura/af-images that referenced this issue Oct 17, 2024
@nsmith-
Copy link
Member

nsmith- commented Oct 21, 2024

Perhaps we can open a new issue but there is more to discuss with respect to image version tags. For example, we may want to start a separate af-image versioning scheme rather than staying in lock-step with coffea.

@oshadura
Copy link
Member

oshadura commented Oct 21, 2024

oh, I didnt want to close it, I just want to test how it looks like fixed version of workflow

@oshadura oshadura reopened this Oct 21, 2024
@oshadura
Copy link
Member

oshadura commented Nov 7, 2024

Now I think I have the workflow similar to what is doing dask:

(all tags https://hub.docker.com/r/coffeateam/coffea-dask-almalinux9/tags)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants