Refactor test files: update type assertions for mocked functions to improve type safety and clarity

Author: habedi

src/agent/tools/definitions/search.ts

@@ -56,8 +56,9 @@ async function implementation(args: z.infer<typeof searchSchema>["arguments"]):
             child.on("error", (err) => {
                 reject(new ToolError(`Command failed to start: ${err.message}`));
             });
-        } catch (err: any) {
-            reject(new ToolError(`Command failed to start: ${err.message}`));
+        } catch (err: unknown) {
+            const message = err instanceof Error ? err.message : String(err);
+            reject(new ToolError(`Command failed to start: ${message}`));
         }
     });
 }

tests/agent/tools/definitions/edit.test.ts

@@ -8,7 +8,6 @@ vi.mock("../../../../src/agent/file-tracker");
 vi.mock("../../../../src/agent/autofix");
 
 describe("edit tool", () => {
-    const mockAssertCanEdit = vi.mocked(fileTracker.assertCanEdit);
     const mockRead = vi.mocked(fileTracker.read);
     const mockWrite = vi.mocked(fileTracker.write);
     const mockAutofixEdit = vi.mocked(autofixEdit);

tests/agent/tools/definitions/list.test.ts

@@ -14,7 +14,7 @@ describe("list tool", () => {
         const mockStat = vi.mocked(fs.stat);
         const mockReaddir = vi.mocked(fs.readdir);
 
-        mockStat.mockResolvedValue({ isDirectory: () => true } as any);
+        mockStat.mockResolvedValue({ isDirectory: () => true } as fs.Stats);
         mockReaddir.mockResolvedValue(["file1.ts", "file2.ts"]);
 
         const { implementation } = listTool;
@@ -29,7 +29,7 @@ describe("list tool", () => {
         const mockStat = vi.mocked(fs.stat);
         const mockReaddir = vi.mocked(fs.readdir);
 
-        mockStat.mockResolvedValue({ isDirectory: () => true } as any);
+        mockStat.mockResolvedValue({ isDirectory: () => true } as fs.Stats);
         mockReaddir.mockResolvedValue([]);
 
         const { implementation } = listTool;
@@ -40,7 +40,7 @@ describe("list tool", () => {
 
     it("should throw a ToolError when the path is not a directory", async () => {
         const mockStat = vi.mocked(fs.stat);
-        mockStat.mockResolvedValue({ isDirectory: () => false } as any);
+        mockStat.mockResolvedValue({ isDirectory: () => false } as fs.Stats);
 
         const { implementation } = listTool;
         await expect(implementation({ path: "/test" })).rejects.toThrow(
@@ -75,7 +75,7 @@ describe("list tool", () => {
         const mockReaddir = vi.mocked(fs.readdir);
         const cwd = process.cwd();
 
-        mockStat.mockResolvedValue({ isDirectory: () => true } as any);
+        mockStat.mockResolvedValue({ isDirectory: () => true } as fs.Stats);
         mockReaddir.mockResolvedValue(["file1.ts", "file2.ts"]);
 
         const { implementation } = listTool;

tests/agent/tools/definitions/mcp.test.ts

@@ -2,7 +2,6 @@ import { describe, it, expect, vi, beforeEach } from "vitest";
 import mcpTool from "../../../../src/agent/tools/definitions/mcp";
 import { Client } from "@modelcontextprotocol/sdk/client/index.js";
 import { StdioClientTransport } from "@modelcontextprotocol/sdk/client/stdio.js";
-import { ToolError } from "../../../../src/agent/errors";
 import type { Config } from "../../../../src/config";
 
 vi.mock("@modelcontextprotocol/sdk/client/index.js");
@@ -12,9 +11,9 @@ describe("mcp tool", () => {
     const mockClient = vi.mocked(Client);
     const mockTransport = vi.mocked(StdioClientTransport);
 
-    let mockConnect: any;
-    let mockCallTool: any;
-    let mockClose: any;
+    let mockConnect: vi.Mock;
+    let mockCallTool: vi.Mock;
+    let mockClose: vi.Mock;
 
     beforeEach(() => {
         vi.resetAllMocks();
@@ -29,23 +28,23 @@ describe("mcp tool", () => {
                 ({
                     connect: mockConnect,
                     callTool: mockCallTool,
-                }) as any,
+                }) as unknown as Client,
         );
         mockTransport.mockImplementation(
             () =>
                 ({
                     close: mockClose,
-                }) as any,
+                }) as unknown as StdioClientTransport,
         );
     });
 
-    const mockConfig: Config = {
+    const mockConfig = {
         mcpServers: {
             testServer: {
                 command: "test-command",
             },
         },
-    } as any;
+    } as unknown as Config;
 
     it("should call an MCP tool and return the text content", async () => {
         mockCallTool.mockResolvedValue({
@@ -143,7 +142,7 @@ describe("mcp tool", () => {
                     args: ["--arg1", "--arg2"],
                 },
             },
-        } as any;
+        } as unknown as Config;
 
         const { implementation } = mcpTool;
         await implementation({ server: "testServer", tool: "testTool" }, configWithArgs);

tests/agent/tools/definitions/search.test.ts

@@ -24,7 +24,7 @@ describe("search tool", () => {
                 }
             }),
         };
-        mockSpawn.mockReturnValue(mockChildProcess as any);
+        mockSpawn.mockReturnValue(mockChildProcess as unknown as ReturnType<typeof spawn>);
 
         const { implementation } = searchTool;
         const result = await implementation({ query: "test" });
@@ -60,7 +60,7 @@ describe("search tool", () => {
                 }
             }),
         };
-        mockSpawn.mockReturnValue(mockChildProcess as any);
+        mockSpawn.mockReturnValue(mockChildProcess as unknown as ReturnType<typeof spawn>);
 
         const { implementation } = searchTool;
         const result = await implementation({ query: "nonexistent" });
@@ -87,7 +87,7 @@ describe("search tool", () => {
                 }
             }),
         };
-        mockSpawn.mockReturnValue(mockChildProcess as any);
+        mockSpawn.mockReturnValue(mockChildProcess as unknown as ReturnType<typeof spawn>);
 
         const { implementation } = searchTool;
         await expect(implementation({ query: "test" })).rejects.toThrow(