Skip to content

[SUGGESTION]: Support for darkmode #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wizlif opened this issue Jan 17, 2023 · 0 comments
Open

[SUGGESTION]: Support for darkmode #344

wizlif opened this issue Jan 17, 2023 · 0 comments
Assignees

Comments

@wizlif
Copy link
Collaborator

wizlif commented Jan 17, 2023

Currently the app theming is using manually set colours from constants.dart, meaning the app looks the same both in light mode and dark mode. This is a bad practice as it doesn't use flutter's inbuilt theming through Theme.of(context).

We can migrate coloring to base on Flutter's theming by using the inbuilt colorSchemes to pass colours around and retire use of colours in contants.dart. This would also come in handy incase we need to support dark mode.

We wouldn't necessarily use FlutterColorSchemes but setup our own colour schemes.

Flutter Theming, Pair Programming with Author of Flex_Color_Scheme! 32+ color schemes in one app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants