Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert Special Character dialog scrolling problem #9559

Closed
eszkadev opened this issue Jul 21, 2024 · 1 comment
Closed

Insert Special Character dialog scrolling problem #9559

eszkadev opened this issue Jul 21, 2024 · 1 comment
Labels
24.04 bug Something isn't working regression Something that was working in the past, but not now unconfirmed

Comments

@eszkadev
Copy link
Contributor

eszkadev commented Jul 21, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Writer
  2. Click on Inser Special Character
  3. Try to scroll characters

Expected Behavior

Smooth scrolling, possible to go to the next page

Actual Behavior

Cannot scroll, size of the scrollable frame bigger than content...

Desktop

(Please complete the following information)

  • Collabora version: 24.04.5.2

Something is wrong with updateSize method:

online/browser/src/control/jsdialog/Widget.ScrolledWindow.js

Line 95 in 0796454

var updateSize = function () {

Regression from 5b03c12
cc @meven
@eszkadev eszkadev added bug Something isn't working unconfirmed labels Jul 21, 2024
@eszkadev eszkadev added the regression Something that was working in the past, but not now label Jul 21, 2024
@eszkadev eszkadev mentioned this issue Jul 25, 2024
Open
@eszkadev eszkadev added the 24.04 label Jul 25, 2024
@eszkadev eszkadev mentioned this issue Aug 12, 2024
Closed
@eszkadev eszkadev mentioned this issue Aug 27, 2024
Merged
eszkadev added a commit that referenced this issue Aug 29, 2024
@eszkadev
Revert "scrollWindow: Corrected the property name from 'scrollwidth' …
d9706a8 
…to 'scrollWidth' in the _scrolledWindowControl function"

This reverts commit 15ffda9.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I19d44db2252de91c0ca637256239d4a9405e1c31
eszkadev added a commit that referenced this issue Aug 29, 2024
@eszkadev
Revert "jsdialog: send less messages for scrolled window"
806a8f2 
This reverts commit fd35bd7.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: If703d2c20ceee4321520aa01a5b55c95e3c27113
eszkadev added a commit that referenced this issue Aug 29, 2024
@eszkadev
Revert "Widget.ScrolledWindow: allow to resize based on content"
3f2c383 
This reverts commit c5cd333.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I24967889c7b9a75d1afcdbdb67e04f45eaf230b6
@eszkadev eszkadev mentioned this issue Aug 29, 2024
Merged
timar pushed a commit that referenced this issue Aug 29, 2024
@eszkadev @timar
Revert "scrollWindow: Corrected the property name from 'scrollwidth' …
2b00482 
…to 'scrollWidth' in the _scrolledWindowControl function"

This reverts commit 15ffda9.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I19d44db2252de91c0ca637256239d4a9405e1c31
timar pushed a commit that referenced this issue Aug 29, 2024
@eszkadev @timar
Revert "jsdialog: send less messages for scrolled window"
0bcebdf 
This reverts commit fd35bd7.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: If703d2c20ceee4321520aa01a5b55c95e3c27113
timar pushed a commit that referenced this issue Aug 29, 2024
@eszkadev @timar
Revert "Widget.ScrolledWindow: allow to resize based on content"
28cf77a 
This reverts commit c5cd333.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I24967889c7b9a75d1afcdbdb67e04f45eaf230b6
@meven
Copy link
Contributor

meven commented Nov 6, 2024

Fixed with #9926

@meven meven closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
24.04 bug Something isn't working regression Something that was working in the past, but not now unconfirmed
Projects
Collabora Online
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meven @eszkadev