Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle limited open Connections due to keepalive connections (cool#9621) #9833

Open
sgothel opened this issue Aug 16, 2024 · 1 comment · May be fixed by #9916
Open

Handle limited open Connections due to keepalive connections (cool#9621) #9833

sgothel opened this issue Aug 16, 2024 · 1 comment · May be fixed by #9916
Assignees
@sgothel
Labels
24.04 enhancement New feature or request

Comments

@sgothel
Copy link

sgothel commented Aug 16, 2024 •
edited
Loading

Is your feature request related to a problem?

Issue #9621 resolved by pull request #9777 keeps connections alive to enhance performance.
This may result in a shortage of available connection on the server and should be addressed

Describe the solution you'd like

We should track inactivity of each socket and close the oldest-inactive sockets
either (a) in general and/or (b) when available connection count is below a threshold.

Describe alternatives you've considered

Alternatively, we may need to close high-frequency short lived connections.
@sgothel sgothel added enhancement New feature or request unconfirmed labels Aug 16, 2024
@sgothel sgothel self-assigned this Aug 16, 2024
@mmeeks mmeeks added 24.04 and removed unconfirmed labels Aug 19, 2024
@mmeeks
Copy link
Contributor

mmeeks commented Aug 19, 2024

Yep - clearly rather related, and important to get this nailed before widely deploying the connection re-using code =)

While we're there - we should shut prolly also detect and shut connections that are not making progress - 'slow' connections and so on that are drip-feeding us data.

Thanks!

@sgothel sgothel linked a pull request Aug 28, 2024 that will close this issue
Open
6 tasks
@sgothel sgothel mentioned this issue Sep 9, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgothel sgothel

Labels
24.04 enhancement New feature or request
Projects
Collabora Online
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle limited open Connections due to keepalive connections CollaboraOnline/online
2 participants
@mmeeks @sgothel