-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Improve Group Node UX with Subgraphs #1077
Comments
Now that this PR is merged ( comfyanonymous/ComfyUI#2666 ), it should be easier to implement subgraphs, right ? There is already an extension for Subgraph nodes: But I think a feature as important as this, should be in the core. |
It looks similar to blender's |
I wonder if some of the code used for the current Group Nodes could be reused. But to add nodes to a Group Node, we need to convert back to nodes; edit the nodes; and then convert to Group Node again. |
Note that this isn't just aesthetic, this could help to discourage the proliferation of node variants. At least for the ones you must install and can't be just exported as JSON itself. If the core nodes provides a good amount of simple primitives people could just regroup them as needed, instead of needing a custom group that reinvents the wheel just to group functionality in a different way. In the past I used simulation software for FPGAs that uses graphs similar to the ones used by ComfyUI, the nested nodes was a key feature, I was really surprised when I found it was impossible using ComfyUI. |
Why such an important function has not been paid attention to is really curious. |
I guess this is because the developers are happy with the option to collapse various nodes into one. Which is useful, but is much less interesting than supporting nested nodes. Subgraphs allows to edit them, while un/compressing becomes impractical once you defined a nodes layout. |
Is there an existing issue for this?
What would your feature do ?
This change would make editing and working with group nodes much easier. This is something that apparently has been discussed a lot in the past, and seeing that the frontend can evolve much faster (and better!) now, I think it would be a good idea to bring it up again.
Proposed workflow
I don't think I would do it justice to propose a workflow for this.
Instead, having a read through this issue and through some of the issues brought up in this comment should provide a lot of context on previous discussions on this.
Additional information
No response
The text was updated successfully, but these errors were encountered: