Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add a button to bypass ( in the node's top right corner ) ( shown on mouseover ) #1126

Open
1 task done
JorgeR81 opened this issue Oct 6, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@JorgeR81
Copy link

JorgeR81 commented Oct 6, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I think bypassing is a feature so important that it deserves a button in each node.

Proposed workflow

The button could be in the node's top right corner.
And it could be shown only when we mouseover this area.

Ideally this would be a node property that we could enable per node type. 
For instance, I would like to bypass a Load Lora or Apply ControlNet, but not a Load Checkpoint or Load ControlNet node. 

Additional information

My current workaround is placing each node in a group of its own, and enabling an rgthree setting, to add bypass buttons to all groups.

I've also made a feature request there to have buttons on the nodes ( rgthree/rgthree-comfy#204 ), a few months ago.
Other users were also interested, but we had no feedback from rgthree on this.
He seems to be even more busy now, so I don't think this is going to be added anytime soon.

So it only works for groups for now :

set

loras

@JorgeR81 JorgeR81 added the enhancement New feature or request label Oct 6, 2024
@JorgeR81
Copy link
Author

JorgeR81 commented Oct 6, 2024

If we can have a button on each widget ( #994 ), I figured that we could also have one in each node.

@pandayummy
Copy link

You can select the node and Ctrl+B

@JorgeR81
Copy link
Author

You can select the node and Ctrl+B

Yeah I know, but once I started using the rgthree toggle in groups, I really liked this method.

@LukeG89
Copy link

LukeG89 commented Oct 11, 2024

In the meanwhile, another good alternative is to simplify the shortcuts like I did:

  • C -> Collapse
  • B -> Bypass
  • M -> Mute

Obviously for the last one I had to replace Model Library shortcut with a new key.

@JorgeR81
Copy link
Author

In the meanwhile, another good alternative is to simplify the shortcuts like I did:

C -> Collapse
B -> Bypass
M -> Mute

Obviously for the last one I had to replace Model Library shortcut with a new key.

Yes, that helps. Thanks !


By the way, do you use "Mute" all that often?

I just use it on the "last node" ( e.g. mute an Image Preview to also disable the respective KSampler ).
But bypass would also work in this case.

I also use "Mute" with the Any Switch (rgthree), but for this I also have the Fast Muter (rgthree).

@LukeG89
Copy link

LukeG89 commented Oct 11, 2024

By the way, do you use "Mute" all that often?

Not that often actually, I just thought to simplify them all. But on second thought, Mute could remain the default one.

@pandayummy
Copy link

Some nodes are very small, not possible to add a button on it.

@JorgeR81
Copy link
Author

JorgeR81 commented Oct 11, 2024

Some nodes are very small, not possible to add a button on it.

In think it could work like this:

  • The button would be hidden by default, in all nodes.
    We would have a right-click menu option to: add bypass toggle ( to all the nodes of the same type ).
    I would like to bypass a "Load Lora" or "Apply ControlNet" node, but not a "Load Checkpoint" or "Load ControlNet".

  • It will not be a bulky button, just one icon ( that could change shape when we click on it ).
    It could be similar to the icons used in the rgthree group toggles ( see image above, in the group's top right corner )

  • The collapsed nodes, could be made just a little longer to fit the icon / button.
    Alternatively, the button could be hidden, if the node is collapsed. I wouldn't mind that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants