Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: z-order of pinned nodes is not saved properly. #1525

Open
dchatel opened this issue Nov 13, 2024 · 1 comment
Open

[Bug]: z-order of pinned nodes is not saved properly. #1525

dchatel opened this issue Nov 13, 2024 · 1 comment
Labels
Potential Bug Untriaged bug

Comments

@dchatel
Copy link

dchatel commented Nov 13, 2024

Frontend Version

v1.3.42

Expected Behavior

you pin some nodes, save the workflow, close the workflow, reload the workflow, you get the exact same graph as you left it.

Actual Behavior

o.mp4

Steps to Reproduce

as shown in video

Debug Logs

N/A

Browser Logs

N/A

Setting JSON

{
"Comfy.DOMClippingEnabled": false,
"Comfy.EditAttention.Delta": "0.1",
"Comfy.NodeInputConversionSubmenus": true,
"Comfy.InvertMenuScrolling": true,
"Comfy.SnapToGrid.GridSize": "5",
"Comfy.ColorPalette": "custom_dark",
"Comfy.WidgetControlMode": "before",
"Comfy.LinkRenderMode": 2,
"Comfy.NodeLibrary.Bookmarks": [],
"Comfy.NodeBadge.NodeIdBadgeMode": "None",
"Comfy.Sidebar.Size": "small",
"Comfy.Sidebar.Location": "right",
"Comfy.UseNewMenu": "Floating",
"Comfy.EnableTooltips": false,
"Comfy.CustomColorPalettes": {
"dark": {
"id": "dark",
"name": "Dark",
"colors": {
"node_slot": {
"*": "",
"ACNAUTOSIZE": "",
"ADEAUTOSIZE": "",
"ADEWARN": "",
"AD_BLOCK": "",
"AD_KEYFRAMES": "",
"AD_SETTINGS": "",
"AUDIO": "",
"AUDIOUPLOAD": "",
"AUDIO_UI": "",
"BASIC_PIPE": "",
"BBOX": "",
"BBOX_DETECTOR": "",
"BOOLEAN": "",
"CAMERACTRL_POSES": "",
"CFG_EXTRAS": "",
"CLIP": "#FFD500",
"CLIPSEGMODEL": "",
"CLIP_SEG": "",
"CLIP_VISION": "#A8DADC",
"CLIP_VISION_OUTPUT": "#ad7452",
"CN_WEIGHTS_EXTRAS": "",
"CONDITIONING": "#FFA931",
"CONTEXTREF_KEYFRAME": "",
"CONTEXTREF_MODE": "",
"CONTEXTREF_TUNE": "",
"CONTEXT_EXTRAS": "",
"CONTEXT_OPTIONS": "",
"CONTROL_NET": "#6EE7B7",
"CONTROL_NET_WEIGHTS": "",
"CPipeAny": "",
"CUSTOM_CFG": "",
"DETAILER_HOOK": "",
"DETAILER_PIPE": "",
"EDITOR_LINK": "",
"ELLA": "",
"ELLA_EMBEDS": "",
"EMBEDS": "",
"EXP_DATA": "",
"FACE": "",
"FIZZFRAME": "",
"FL2MODEL": "",
"FLOAT": "",
"FLOATS": "",
"GIF": "",
"GLIGEN": "",
"GUIDER": "#66FFFF",
"HIDDEN": "",
"IMAGE": "#64B5F6",
"IMAGEUPLOAD": "",
"IMAGE_INJECT": "",
"IMAGE_INJECT_OPTIONS": "",
"INDEXES": "",
"INPAINT_MODEL": "",
"INSIGHTFACE": "",
"INT": "",
"INT,FLOAT": "",
"INT:seed": "",
"INTERPOLATION_STATES": "",
"INTS": "",
"IPADAPTER": "",
"IPADAPTER_PARAMS": "",
"IPADAPTER_PIPE": "",
"ITERATION_OPTS": "",
"JSON": "",
"KSAMPLER": "",
"KSAMPLER_ADVANCED": "",
"LATENT": "#FF9CF9",
"LATENT_KEYFRAME": "",
"LBW_MODEL": "",
"LORA_HOOK": "",
"LORA_HOOK_KEYFRAMES": "",
"LORA_PARAMS": "",
"ListString": "",
"MASK": "#81C784",
"METADATA_RAW": "",
"MODEL": "#B39DDB",
"MOTION_LORA": "",
"MOTION_MODEL_ADE": "",
"MULTIVAL": "",
"M_MODELS": "",
"NAIVEREUSE_KEYFRAME": "",
"NOISE": "#B0B0B0",
"NOISE_LAYERS": "",
"NORMALIZED_AMPLITUDE": "",
"OPTICAL_FLOW": "",
"PEFTLORA": "",
"PER_BLOCK": "",
"PE_ADJUST": "",
"PHOTOMAKER": "",
"PIA_INPUT": "",
"PK_HOOK": "",
"PLUS_INPUT": "",
"POSE_KEYPOINT": "",
"RECT": "",
"REGIONAL_IPADAPTER": "",
"REGIONAL_PROMPTS": "",
"REMBG_SESSION": "",
"RGTHREE_CONTEXT": "",
"SAMPLER": "#ECB4B4",
"SAMPLER_PARAMS": "",
"SAMPLE_SETTINGS": "",
"SAM_MODEL": "",
"SCHEDULER_FUNC": "",
"SEGM_DETECTOR": "",
"SEGS": "",
"SEGS_HEADER": "",
"SEGS_PREPROCESSOR": "",
"SEG_ELT": "",
"SEG_ELT_bbox": "",
"SEG_ELT_control_net_wrapper": "",
"SEG_ELT_crop_region": "",
"SELECTEDBLOCKS": "",
"SIGMAS": "#CDFFCD",
"SIGMA_SCHEDULE": "",
"SPARSE_METHOD": "",
"SRGADVOPTIONSCONFIG": "",
"STRING": "",
"STYLE_MODEL": "#C2FFAE",
"T5_TEXT_ENCODER": "",
"TAESD": "#DCC274",
"TIMESTEPS_COND": "",
"TIMESTEP_KEYFRAME": "",
"TRACKING": "",
"TRANSFORMERS_CLASSIFIER": "",
"UPSCALER": "",
"UPSCALER_HOOK": "",
"UPSCALE_MODEL": "",
"VAE": "#FF6E6E",
"VALUES_REPLACE": "",
"VHS_AUDIO": "",
"VHS_BatchManager": "",
"VHS_DUMMY_NONE": "",
"VHS_FILENAMES": "",
"VHS_VIDEOINFO": "",
"VIEW_OPTS": "",
"WARP": "",
"WEBCAM": "",
"WEIGHTS_STRATEGY": "",
"WEIGHT_ADJUST": "",
"XY": "",
"ZIPPED_PROMPT": "",
"euler,euler_cfg_pp,euler_ancestral,euler_ancestral_cfg_pp,heun,heunpp2,dpm_2,dpm_2_ancestral,lms,dpm_fast,dpm_adaptive,dpmpp_2s_ancestral,dpmpp_2s_ancestral_cfg_pp,dpmpp_sde,dpmpp_sde_gpu,dpmpp_2m,dpmpp_2m_sde,dpmpp_2m_sde_gpu,dpmpp_3m_sde,dpmpp_3m_sde_gpu,ddpm,lcm,ipndm,ipndm_v,deis,ddim,uni_pc,uni_pc_bh2": "",
"flux\STOIQONewrealityFLUXSD_F1DPreAlpha.safetensors,flux\flux1-dev-bnb-nf4.safetensors,flux\flux1DevV1V2Flux1_flux1DevBNBNF4V2.safetensors,sd1-5\ERv10.RC1.fp16.safetensors,sd1-5\ERv10.RC2.fp16.safetensors,sd1-5\ERv10.RC3.fp16.safetensors,sd1-5\ERv7.RC3.fp16.safetensors,sd1-5\ERv8.RC1.fp16.safetensors,sd1-5\ERv8.RC2f.fp16.safetensors,sd1-5\ERv8.RC3.fp16.safetensors,sd1-5\ERv8.RC4.fp16.safetensors,sd1-5\ERv8.RC5.fp16.safetensors,sd1-5\ERv9.RC1.clip-vit-large14.fp16.safetensors,sd1-5\ERv9.RC1.fp16.safetensors,sd1-5\ERv9.RC10.fp16.safetensors,sd1-5\ERv9.RC10.safetensors,sd1-5\ERv9.RC2_00001_.safetensors,sd1-5\ERv9.RC3.fp16.safetensors,sd1-5\ERv9.RC4.fp16.safetensors,sd1-5\ERv9.RC5.fp16.safetensors,sd1-5\ERv9.RC6.fp16.safetensors,sd1-5\ERv9.RC7.safetensors,sd1-5\ERv9.RC8.fp16.safetensors,sd1-5\ERv9.RC9.fp16.safetensors,sd1-5\abyssMix_v17.safetensors,sd1-5\anatomyLight_v10.safetensors,sd1-5\anything-v4.5-1788-1925-0121.safetensors,sd1-5\arthemyComics_v70.safetensors,sd1-5\astranime_V6.safetensors,sd1-5\cardosAnime_v20.safetensors,sd1-5\comicsVision_v10.safetensors,sd1-5\dreamshaper_8.safetensors,sd1-5\endlessreality_v4.safetensors,sd1-5\epicrealism_naturalSinRC1VAE.safetensors,sd1-5\eraEstheticRetroAnime_retroV75RV.safetensors,sd1-5\hyperRealism_30.safetensors,sd1-5\jibMixRealisticSD15_v10.safetensors,sd1-5\lemixrealisticer_v21.safetensors,sd1-5\linexdiffusion_v11.safetensors,sd1-5\meinaalter_v3.safetensors,sd1-5\mybeautyphotomix_v10.safetensors,sd1-5\pixelmix_v20.safetensors,sd1-5\realDream_15SD15.safetensors,sd1-5\realhotspice_v15.safetensors,sd1-5\realisticStockPhoto_v30SD15.safetensors,sd1-5\realisticVisionV60B1_v51VAE.safetensors,sd1-5\reallife_v40.safetensors,sd1-5\realspice_v30Trinity.safetensors,sd1-5\revAnimated_v122EOL.safetensors,sd1-5\serenity_v21Safetensors.safetensors,sd1-5\v1-5-pruned-emaonly.ckpt,sd1-5\v1-5-pruned.ckpt,sd3\2b_1024\sd3_medium.safetensors,sd3\2b_1024\sd3_medium_incl_clips.safetensors,sd3\2b_1024\sd3_medium_incl_clips_t5xxlfp8.safetensors,sdxl\AnythingXL_xl.safetensors,sdxl\STOIQONewrealityFLUXSD_XLPRO.safetensors,sdxl\jibMixRealisticXL_v140CrystalClarity.safetensors,sdxl\leosamsHelloworldXL_helloworldXL70.safetensors,sdxl\realvisxlV40_v40Bakedvae.safetensors": "",
"model": "",
"none,AnimeFace_SemSegPreprocessor,AnyLineArtPreprocessor_aux,BinaryPreprocessor,CannyEdgePreprocessor,ColorPreprocessor,DensePosePreprocessor,DepthAnythingPreprocessor,Zoe_DepthAnythingPreprocessor,DepthAnythingV2Preprocessor,DSINE-NormalMapPreprocessor,DWPreprocessor,AnimalPosePreprocessor,HEDPreprocessor,FakeScribblePreprocessor,LeReS-DepthMapPreprocessor,LineArtPreprocessor,AnimeLineArtPreprocessor,LineartStandardPreprocessor,Manga2Anime_LineArt_Preprocessor,MediaPipe-FaceMeshPreprocessor,MeshGraphormer-DepthMapPreprocessor,Metric3D-DepthMapPreprocessor,Metric3D-NormalMapPreprocessor,MiDaS-NormalMapPreprocessor,MiDaS-DepthMapPreprocessor,M-LSDPreprocessor,BAE-NormalMapPreprocessor,OneFormer-COCO-SemSegPreprocessor,OneFormer-ADE20K-SemSegPreprocessor,OpenposePreprocessor,PiDiNetPreprocessor,ImageLuminanceDetector,ImageIntensityDetector,ScribblePreprocessor,Scribble_XDoG_Preprocessor,Scribble_PiDiNet_Preprocessor,SAMPreprocessor,ShufflePreprocessor,TEEDPreprocessor,TilePreprocessor,TTPlanet_TileGF_Preprocessor,TTPlanet_TileSimple_Preprocessor,UniFormer-SemSegPreprocessor,SemSegPreprocessor,Zoe-DepthMapPreprocessor": "",
"normal,karras,exponential,sgm_uniform,simple,ddim_uniform,beta": "",
"normal,karras,exponential,sgm_uniform,simple,ddim_uniform,beta,AYS SDXL,AYS SD1,AYS SVD,GITS[coeff=1.2]": ""
},
"litegraph_base": {
"BACKGROUND_IMAGE": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAGQAAABkCAIAAAD/gAIDAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAQBJREFUeNrs1rEKwjAUhlETUkj3vP9rdmr1Ysammk2w5wdxuLgcMHyptfawuZX4pJSWZTnfnu/lnIe/jNNxHHGNn//HNbbv+4dr6V+11uF527arU7+u63qfa/bnmh8sWLBgwYJlqRf8MEptXPBXJXa37BSl3ixYsGDBMliwFLyCV/DeLIMFCxYsWLBMwSt4Be/NggXLYMGCBUvBK3iNruC9WbBgwYJlsGApeAWv4L1ZBgsWLFiwYJmCV/AK3psFC5bBggULloJX8BpdwXuzYMGCBctgwVLwCl7Be7MMFixYsGDBsu8FH1FaSmExVfAxBa/gvVmwYMGCZbBg/W4vAQYA5tRF9QYlv/QAAAAASUVORK5CYII=",
"CLEAR_BACKGROUND_COLOR": "#222",
"NODE_TITLE_COLOR": "#999",
"NODE_SELECTED_TITLE_COLOR": "#FFF",
"NODE_TEXT_SIZE": 14,
"NODE_TEXT_COLOR": "#AAA",
"NODE_SUBTEXT_SIZE": 12,
"NODE_DEFAULT_COLOR": "#333",
"NODE_DEFAULT_BGCOLOR": "#353535",
"NODE_DEFAULT_BOXCOLOR": "#666",
"NODE_DEFAULT_SHAPE": "box",
"NODE_BOX_OUTLINE_COLOR": "#FFF",
"DEFAULT_SHADOW_COLOR": "rgba(0,0,0,0)",
"DEFAULT_GROUP_FONT": 24,
"WIDGET_BGCOLOR": "#222",
"WIDGET_OUTLINE_COLOR": "#666",
"WIDGET_TEXT_COLOR": "#DDD",
"WIDGET_SECONDARY_TEXT_COLOR": "#999",
"LINK_COLOR": "#9A9",
"EVENT_LINK_COLOR": "#A86",
"CONNECTING_LINK_COLOR": "#AFA",
"BADGE_FG_COLOR": "#FFF",
"BADGE_BG_COLOR": "#0F1F0F"
},
"comfy_base": {
"fg-color": "#fff",
"bg-color": "#202020",
"comfy-menu-bg": "#353535",
"comfy-input-bg": "#222",
"input-text": "#ddd",
"descrip-text": "#999",
"drag-text": "#ccc",
"error-text": "#ff4444",
"border-color": "#4e4e4e",
"tr-even-bg-color": "#222",
"tr-odd-bg-color": "#353535",
"content-bg": "#4e4e4e",
"content-fg": "#fff",
"content-hover-bg": "#222",
"content-hover-fg": "#fff"
}
}
}
},
"pysssss.SnapToGrid": true,
"Comfy.NodeBadge.NodeSourceBadgeMode": "None",
"pysssss.WidgetDefaults": "[{"node":"SaveImage","widget":"filename_prefix","value":"%date:yyyy-MM-dd hh-mm-ss%"},{"node":"VHS_VideoCombine","widget":"filename_prefix","value":"%date:yyyy-MM-dd hh-mm-ss%"}]",
"Comfy.Graph.CanvasMenu": false,
"Comfy.Keybinding.NewBindings": [
{
"commandId": "Comfy.Canvas.ResetView",
"combo": {
"key": "v",
"ctrl": false,
"alt": false,
"shift": false
}
}
],
"Comfy.Keybinding.UnsetBindings": [
{
"commandId": "Comfy.ClearWorkflow",
"combo": {
"key": "Backspace",
"ctrl": false,
"alt": false,
"shift": false
}
},
{
"commandId": "Comfy.Interrupt",
"combo": {
"key": "Enter",
"ctrl": true,
"alt": true,
"shift": false
}
}
],
"Comfy.Workflow.WorkflowTabsPosition": "Sidebar",
"AE.showlinks": 0
}

What browsers do you use to access the UI ?

Mozilla Firefox, Microsoft Edge

Other

No response

┆Issue is synchronized with this Notion page by Unito

@dchatel dchatel added the Potential Bug Untriaged bug label Nov 13, 2024
@EasyComfyui
Copy link

same #1494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Untriaged bug
Projects
None yet
Development

No branches or pull requests

2 participants