Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Configurable bus node ( like Trung0246 highway node ) #1716

Open
1 task done
JorgeR81 opened this issue Nov 27, 2024 · 1 comment
Open
1 task done
Labels
enhancement New feature or request

Comments

@JorgeR81
Copy link

JorgeR81 commented Nov 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

We should have a native, configurable "bus" / pipe node.

We have other bus nodes, with fixed inputs and outputs.
But this would be much more flexible.

Proposed workflow

It could work like the Trung0246 Highway node ( https://github.com/Trung0246/ComfyUI-0246 ).

It would have an input field to set the input and output names. And a button to apply the settings.
And each input could accept any type of data.

t01

Additional information

See example use case bellow, with a complex workflow.

┆Issue is synchronized with this Notion page by Unito

@JorgeR81 JorgeR81 added the enhancement New feature or request label Nov 27, 2024
@JorgeR81
Copy link
Author

JorgeR81 commented Nov 27, 2024

Example:

Here I have a workflow with a 5 image batch that goes through multiple stages of processing (ControlNet, InstantID, IPAdapers...).

I also need each individual image and mask to be available at each stage ( to use the full features of InstantID and IPAdaper ).
But I want a separate loading area for all the images, since the workflow it's quite large.
And I need to have the nodes to create the batches, create masks, prepare images for Clip Vision, and set IPAdapter embedding weights, next to the images ( so that I can see more clearly, to each image I'm applying to each setting ).

So I need a massive bus.

Below I have 2 variations of the same workflow.

  • Trung0246 highway
  • Regular bus node + reroute and "pass" nodes ( for all extra images and masks )

Old workflow

b00


New worflow ( with Trung0246 Highway nodes )

x1


Image loading area ( with Trung0246 Highway nodes expanded )

I can collect images, masks, Clip Vision images and embedding weights ( FLOAT ), for each image

tm


Trung Highway nodes ( expanded view )

Look at these seamless transitions from ControlNet to InstantID to IPAdapter FaceID groups. So clean !
We only have the inputs and outputs we need and in the correct order !

z0


z1


z02


Old workflow

I used "pass" nodes and reroute nodes for all individual images, masks, Clip Vision images and IPAdapter embedding weights.
This bus setup would be even larger without the rgthree bus node.

x00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant